cc taxi: enable enum readability-identifier-naming

commit_hash:230a80db3fab34ebbed9cea9c561ab1aa204128a

Author: TTPO100AJIEX

.clang-tidy

@@ -172,6 +172,10 @@ CheckOptions:
     value: CamelCase
   - key: readability-identifier-naming.StaticConstantPrefix
     value: k
+  - key: readability-identifier-naming.EnumConstantCase
+    value: CamelCase
+  - key: readability-identifier-naming.EnumConstantPrefix
+    value: k
   - key: readability-identifier-naming.MacroDefinitionCase
     value: UPPER_CASE
   - key: readability-identifier-naming.NamespaceCase

chaotic/integration_tests/tests/lib/array.cpp

@@ -79,7 +79,7 @@ TEST(Array, FromObjectShouldThrow) {
     UEXPECT_THROW_MSG(
         json.As<Arr>(),
         formats::json::TypeMismatchException,
-        "Error at path '/': Wrong type. Expected: arrayValue, actual: objectValue"
+        "Error at path '/': Wrong type. Expected: kArrayValue, actual: kObjectValue"
     );
 }
 

chaotic/integration_tests/tests/lib/primitive.cpp

@@ -54,11 +54,7 @@ TEST(Primitive, WrongType) {
     try {
         const std::string x = kJson["foo"].As<String>();
     } catch (const std::exception& e) {
-        EXPECT_EQ(
-            std::string(e.what()),
-            "Error at path 'foo': Wrong type. Expected: stringValue, actual: "
-            "intValue"
-        );
+        EXPECT_EQ(std::string(e.what()), "Error at path 'foo': Wrong type. Expected: kStringValue, actual: kIntValue");
     }
 }
 

core/include/userver/clients/http/response.hpp

@@ -47,7 +47,7 @@ class Response final {
     /// status_code
     Status status_code() const;
     /// check status code
-    bool IsOk() const { return status_code() == Status::OK; }
+    bool IsOk() const { return status_code() == Status::kOk; }
     bool IsError() const { return static_cast<uint16_t>(status_code()) >= 400; }
 
     static void RaiseForStatus(int code, const LocalStats& stats);
@@ -65,7 +65,7 @@ class Response final {
     Headers headers_;
     CookiesMap cookies_;
     std::string response_;
-    Status status_code_{Status::Invalid};
+    Status status_code_{Status::kInvalid};
     LocalStats stats_;
 };
 

core/include/userver/error_injection/hook.hpp

@@ -23,27 +23,27 @@ class Hook final {
     /// @throws ErrorException in case of artificial error
     template <typename TimeoutException, typename ErrorException>
     void PreHook() {
-        if (verdict_ == Verdict::Skip) {
+        if (verdict_ == Verdict::kSkip) {
             // fast path
             return;
         }
 
         switch (verdict_) {
-            case Verdict::Error:
+            case Verdict::kError:
                 LOG_ERROR() << "Error injection hook triggered verdict: error";
                 throw ErrorException{"error injection"};
 
-            case Verdict::Timeout:
+            case Verdict::kTimeout:
                 LOG_ERROR() << "Error injection hook triggered verdict: timeout";
                 {
                     auto scope_time = tracing::Span::CurrentSpan().CreateScopeTime("error_injection_timeout");
                     engine::InterruptibleSleepUntil(deadline_);
                 }
                 throw TimeoutException{"error injection"};
 
-            case Verdict::MaxDelay:
-            case Verdict::RandomDelay:
-            case Verdict::Skip:
+            case Verdict::kMaxDelay:
+            case Verdict::kRandomDelay:
+            case Verdict::kSkip:
                 // pass
                 ;
         }
@@ -52,7 +52,7 @@ class Hook final {
     /// Must be called just after operation. May sleep for some time,
     /// or do nothing.
     void PostHook() {
-        if (verdict_ == Verdict::Skip) {
+        if (verdict_ == Verdict::kSkip) {
             // fast path
             return;
         }

core/include/userver/error_injection/settings.hpp

@@ -12,14 +12,14 @@ namespace error_injection {
 
 /// What error injection hook may decide to do
 enum class Verdict {
-    Error,        ///< return error
-    Timeout,      ///< wait for deadline and return error
-    MaxDelay,     ///< wait for deadline w/o returning an error
-    RandomDelay,  ///< wait for [0; deadline] w/o returning an error
+    kError,        ///< return error
+    kTimeout,      ///< wait for deadline and return error
+    kMaxDelay,     ///< wait for deadline w/o returning an error
+    kRandomDelay,  ///< wait for [0; deadline] w/o returning an error
 
     // Skip must be the last
 
-    Skip,  ///< no error
+    kSkip,  ///< no error
 };
 
 /// Artificial error injection settings

core/include/userver/utils/hedged_request.hpp

@@ -89,7 +89,7 @@ namespace impl {
 using Clock = utils::datetime::SteadyClock;
 using TimePoint = Clock::time_point;
 
-enum class Action { StartTry, Stop };
+enum class Action { kStartTry, kStop };
 
 struct PlanEntry {
 public:
@@ -163,9 +163,9 @@ struct Context {
     void Prepare(TimePoint start_time) {
         const auto request_count = GetRequestsCount();
         for (std::size_t request_id = 0; request_id < request_count; ++request_id) {
-            plan_.emplace(start_time, request_id, 0, Action::StartTry);
+            plan_.emplace(start_time, request_id, 0, Action::kStartTry);
         }
-        plan_.emplace(start_time + settings_.timeout_all, 0, 0, Action::Stop);
+        plan_.emplace(start_time + settings_.timeout_all, 0, 0, Action::kStop);
         subrequests_.reserve(settings_.max_attempts * request_count);
     }
 
@@ -264,7 +264,7 @@ struct Context {
         request_state.subrequest_indices.push_back(idx);
         input_by_subrequests_[idx] = request_index;
         attempts_made++;
-        plan_.emplace(now + settings_.hedging_delay, request_index, attempts_made, Action::StartTry);
+        plan_.emplace(now + settings_.hedging_delay, request_index, attempts_made, Action::kStartTry);
     }
 
     /// Called on getting error in request with @param request_idx
@@ -277,7 +277,7 @@ struct Context {
             return;
         }
 
-        plan_.emplace(now + retry_delay, request_idx, request_state.attempts_made, Action::StartTry);
+        plan_.emplace(now + retry_delay, request_idx, request_state.attempts_made, Action::kStartTry);
     }
 
     void OnNonRetriableReply(std::size_t request_idx) { FinishAllSubrequests(request_idx); }
@@ -389,10 +389,10 @@ auto HedgeRequestsBulk(std::vector<RequestStrategy> inputs, HedgingSettings hedg
                 }
                 const auto [timestamp, request_index, attempt_id, action] = *plan_entry;
                 switch (action) {
-                    case Action::StartTry:
+                    case Action::kStartTry:
                         context.OnActionStartTry(request_index, attempt_id, timestamp);
                         break;
-                    case Action::Stop:
+                    case Action::kStop:
                         context.OnActionStop();
                         break;
                 }

core/src/clients/http/form_test.cpp

@@ -120,7 +120,7 @@ UTEST(CurlFormTest, MultipartFileWithContentType) {
             .timeout(std::chrono::milliseconds(100))
             .perform();
 
-    EXPECT_EQ(resp->status_code(), clients::http::Status::OK);
+    EXPECT_EQ(resp->status_code(), clients::http::Status::kOk);
 }
 
 UTEST(CurlFormTest, FilesWithContentType) {
@@ -141,7 +141,7 @@ UTEST(CurlFormTest, FilesWithContentType) {
             .timeout(std::chrono::milliseconds(100))
             .perform();
 
-    EXPECT_EQ(resp->status_code(), clients::http::Status::OK);
+    EXPECT_EQ(resp->status_code(), clients::http::Status::kOk);
 }
 
 UTEST(CurlFormTest, FormMovable) {
@@ -170,7 +170,7 @@ UTEST(CurlFormTest, FormMovable) {
             .timeout(std::chrono::milliseconds(100))
             .perform();
 
-    EXPECT_EQ(resp->status_code(), clients::http::Status::OK);
+    EXPECT_EQ(resp->status_code(), clients::http::Status::kOk);
 }
 
 USERVER_NAMESPACE_END

core/src/clients/http/request_state.cpp

@@ -974,7 +974,7 @@ void RequestState::ResetDataForNewRequest() {
     SetBaggageHeader(easy());
 
     response_ = std::make_shared<Response>();
-    response_->SetStatusCode(Status::InternalServerError);
+    response_->SetStatusCode(Status::kInternalServerError);
 
     is_cancelled_ = false;
     retry_.current = 1;

core/src/components/minimal_server_component_list_test.cpp

@@ -198,7 +198,7 @@ TEST_F(ServerMinimalComponentList, InvalidDynamicConfigParam) {
     const auto expected_exception_message = fmt::format(
         "Cannot start component dynamic-config: {} while parsing dynamic config "
         "USERVER_LOG_DYNAMIC_DEBUG. Error at path "
-        "'USERVER_LOG_DYNAMIC_DEBUG.force-enabled': Wrong type. Expected: arrayValue, actual: intValue",
+        "'USERVER_LOG_DYNAMIC_DEBUG.force-enabled': Wrong type. Expected: kArrayValue, actual: kIntValue",
         // NOTE: GetTypeName(typeid(T)) for old compilers.
         compiler::GetTypeName(typeid(formats::json::TypeMismatchException))
     );