refactor core: separate HttpReader and ConnectionBase

commit_hash:e7514eeb0dec18c7bda1d8949c61ab4e87f729eb

Author: ArkadyRudenko

.mapping.json

@@ -1953,17 +1953,21 @@
   "core/src/server/middlewares/rate_limit.hpp":"taxi/uservices/userver/core/src/server/middlewares/rate_limit.hpp",
   "core/src/server/middlewares/tracing.cpp":"taxi/uservices/userver/core/src/server/middlewares/tracing.cpp",
   "core/src/server/middlewares/tracing.hpp":"taxi/uservices/userver/core/src/server/middlewares/tracing.hpp",
-  "core/src/server/net/connection.cpp":"taxi/uservices/userver/core/src/server/net/connection.cpp",
-  "core/src/server/net/connection.hpp":"taxi/uservices/userver/core/src/server/net/connection.hpp",
+  "core/src/server/net/connection_base.cpp":"taxi/uservices/userver/core/src/server/net/connection_base.cpp",
+  "core/src/server/net/connection_base.hpp":"taxi/uservices/userver/core/src/server/net/connection_base.hpp",
   "core/src/server/net/connection_config.cpp":"taxi/uservices/userver/core/src/server/net/connection_config.cpp",
   "core/src/server/net/connection_config.hpp":"taxi/uservices/userver/core/src/server/net/connection_config.hpp",
   "core/src/server/net/connection_test.cpp":"taxi/uservices/userver/core/src/server/net/connection_test.cpp",
   "core/src/server/net/create_socket.cpp":"taxi/uservices/userver/core/src/server/net/create_socket.cpp",
   "core/src/server/net/create_socket.hpp":"taxi/uservices/userver/core/src/server/net/create_socket.hpp",
   "core/src/server/net/endpoint_info.cpp":"taxi/uservices/userver/core/src/server/net/endpoint_info.cpp",
   "core/src/server/net/endpoint_info.hpp":"taxi/uservices/userver/core/src/server/net/endpoint_info.hpp",
+  "core/src/server/net/http1_connection.cpp":"taxi/uservices/userver/core/src/server/net/http1_connection.cpp",
+  "core/src/server/net/http1_connection.hpp":"taxi/uservices/userver/core/src/server/net/http1_connection.hpp",
   "core/src/server/net/http2_connection.cpp":"taxi/uservices/userver/core/src/server/net/http2_connection.cpp",
   "core/src/server/net/http2_connection.hpp":"taxi/uservices/userver/core/src/server/net/http2_connection.hpp",
+  "core/src/server/net/http_socket_reader.cpp":"taxi/uservices/userver/core/src/server/net/http_socket_reader.cpp",
+  "core/src/server/net/http_socket_reader.hpp":"taxi/uservices/userver/core/src/server/net/http_socket_reader.hpp",
   "core/src/server/net/listener.cpp":"taxi/uservices/userver/core/src/server/net/listener.cpp",
   "core/src/server/net/listener.hpp":"taxi/uservices/userver/core/src/server/net/listener.hpp",
   "core/src/server/net/listener_config.cpp":"taxi/uservices/userver/core/src/server/net/listener_config.cpp",

core/functional_tests/dump_coroutines/tests/test_dump_metrics.py

@@ -1,4 +1,4 @@
-SYMBOL = 'server::net::Connection::ListenForRequests()'
+SYMBOL = 'server::net::Http1Connection::ListenForRequests()'
 
 
 async def test_dump_coroutines(monitor_client):

core/functional_tests/http2server/tests/test_http2server.py

@@ -220,7 +220,7 @@ async def test_http1_broken_bytes(service_client, create_socket):
             await sock.recv(1024, timeout=1.0)
         await sock.sendall(b'garbage')
         r = await sock.recv(1024)
-        assert 'HTTP/1.1 400 Bad Request' in r.decode('utf-8')
+        assert len(r.decode('utf-8')) == 0
 
 
 async def _send_and_receive(sock, conn):

core/include/userver/server/http/http_request.hpp

@@ -218,7 +218,7 @@ class HttpRequest final {
     /// @cond
     void SetRequestBody(std::string body);
     void ParseArgsFromBody();
-    bool IsFinal() const;
+    bool IsFinal() const noexcept;
     /// @endcond
 
     /// @brief Set the response status code.
@@ -231,15 +231,15 @@ class HttpRequest final {
     /// was set to `false` and this is a compressed request.
     bool IsBodyCompressed() const;
 
-    HttpResponse& GetHttpResponse() const;
+    HttpResponse& GetHttpResponse() const noexcept;
 
     /// Get approximate time point of request handling start
     std::chrono::steady_clock::time_point GetStartTime() const;
 
     /// @cond
     void MarkAsInternalServerError() const;
 
-    void SetStartSendResponseTime();
+    void SetStartSendResponseTime() noexcept;
     void SetFinishSendResponseTime();
 
     void WriteAccessLogs(

core/include/userver/server/http/http_response.hpp

@@ -88,7 +88,7 @@ class HttpResponse final : public request::ResponseBase {
     /// @brief Set the HTTP response status code.
     /// @returns true if the status was set. Returns false if headers
     /// were already sent for stream'ed response and the new status was not set.
-    bool SetStatus(HttpStatus status);
+    bool SetStatus(HttpStatus status) noexcept;
 
     /// @brief Set the end of system headers.
     /// All headers written before this call are considered system; after - user.

core/include/userver/server/request/response_base.hpp

@@ -97,7 +97,7 @@ class ResponseBase {
     bool IsLimitReached() const;
 
     bool IsReady() const { return is_ready_; }
-    bool IsSent() const { return is_sent_; }
+    bool IsSent() const noexcept { return is_sent_; }
     size_t BytesSent() const { return bytes_sent_; }
     std::chrono::steady_clock::time_point ReadyTime() const { return ready_time_; }
     std::chrono::steady_clock::time_point SentTime() const { return sent_time_; }

core/src/server/http/http2_session.cpp

@@ -213,7 +213,9 @@ long Http2Session::OnSend(nghttp2_session* session, const uint8_t* data, size_t
     UASSERT(data);
     auto& parser = GetParser(user_data);
     if (parser.socket_ != nullptr) {
-        return parser.socket_->WriteAll(data, len, {});
+        const auto send = parser.socket_->WriteAll(data, len, {});
+        LOG_TRACE() << fmt::format("Written {} bytes, expected to write {}.", send, len);
+        return send;
     }
     return NGHTTP2_ERR_WOULDBLOCK;
 }

core/src/server/http/http_request.cpp

@@ -277,7 +277,7 @@ void HttpRequest::ParseArgsFromBody() {
     );
 }
 
-bool HttpRequest::IsFinal() const { return pimpl_->is_final; }
+bool HttpRequest::IsFinal() const noexcept { return pimpl_->is_final; }
 
 void HttpRequest::SetResponseStatus(HttpStatus status) const { pimpl_->response.SetStatus(status); }
 
@@ -286,7 +286,7 @@ bool HttpRequest::IsBodyCompressed() const {
     return !encoding.empty() && encoding != "identity";
 }
 
-HttpResponse& HttpRequest::GetHttpResponse() const { return pimpl_->response; }
+HttpResponse& HttpRequest::GetHttpResponse() const noexcept { return pimpl_->response; }
 
 std::chrono::steady_clock::time_point HttpRequest::GetStartTime() const { return pimpl_->start_time; }
 
@@ -354,7 +354,9 @@ void HttpRequest::SetResponseNotifyTime(std::chrono::steady_clock::time_point no
     pimpl_->response_notify_time = now;
 }
 
-void HttpRequest::SetStartSendResponseTime() { pimpl_->start_send_response_time = std::chrono::steady_clock::now(); }
+void HttpRequest::SetStartSendResponseTime() noexcept {
+    pimpl_->start_send_response_time = std::chrono::steady_clock::now();
+}
 
 void HttpRequest::SetFinishSendResponseTime() {
     pimpl_->finish_send_response_time = std::chrono::steady_clock::now();

core/src/server/http/http_response.cpp

@@ -196,7 +196,7 @@ void HttpResponse::SetContentEncoding(std::string encoding) {
     SetHeader(USERVER_NAMESPACE::http::headers::kContentEncoding, std::move(encoding));
 }
 
-bool HttpResponse::SetStatus(HttpStatus status) {
+bool HttpResponse::SetStatus(HttpStatus status) noexcept {
     if (headers_end_.IsReady()) {
         // Attempt to set headers for Stream'ed response after it is already set
         return false;
@@ -451,6 +451,7 @@ void SetThrottleReason(http::HttpResponse& http_response, std::string log_reason
 void HttpResponse::SetStreamBody() {
     UASSERT(body_stream_producer_.index() == 0);
     if (GetStreamId().has_value()) {
+        UINVARIANT(false, "Streaming in HTTP/2.0 is not supported currently.");
         body_stream_producer_.emplace<impl::Http2StreamEventProducer>(GetStreamProducer());
     } else {
         UASSERT(!body_stream_);