feat mongo: remove MONGO_DEADLINE_PROPAGATION_ENABLED_V2

Vibe-coded at Zero Cost Conf 😎
Fixes: #449

Tests: протестировано CI

Pull Request resolved: #984
commit_hash:fce5760d66742781716a7420c10f19f90bb47989

Author: GitSparTV

.mapping.json

@@ -2715,8 +2715,8 @@
   "mongo/dynamic_configs/MONGO_CONGESTION_CONTROL_ENABLED.yaml":"taxi/uservices/userver/mongo/dynamic_configs/MONGO_CONGESTION_CONTROL_ENABLED.yaml",
   "mongo/dynamic_configs/MONGO_CONGESTION_CONTROL_SETTINGS.yaml":"taxi/uservices/userver/mongo/dynamic_configs/MONGO_CONGESTION_CONTROL_SETTINGS.yaml",
   "mongo/dynamic_configs/MONGO_CONNECTION_POOL_SETTINGS.yaml":"taxi/uservices/userver/mongo/dynamic_configs/MONGO_CONNECTION_POOL_SETTINGS.yaml",
-  "mongo/dynamic_configs/MONGO_DEADLINE_PROPAGATION_ENABLED_V2.yaml":"taxi/uservices/userver/mongo/dynamic_configs/MONGO_DEADLINE_PROPAGATION_ENABLED_V2.yaml",
   "mongo/dynamic_configs/MONGO_DEFAULT_MAX_TIME_MS.yaml":"taxi/uservices/userver/mongo/dynamic_configs/MONGO_DEFAULT_MAX_TIME_MS.yaml",
+  "mongo/dynamic_configs/USERVER_DEADLINE_PROPAGATION_ENABLED.yaml":"taxi/uservices/userver/mongo/dynamic_configs/USERVER_DEADLINE_PROPAGATION_ENABLED.yaml",
   "mongo/functional_tests/CMakeLists.txt":"taxi/uservices/userver/mongo/functional_tests/CMakeLists.txt",
   "mongo/functional_tests/basic_chaos/CMakeLists.txt":"taxi/uservices/userver/mongo/functional_tests/basic_chaos/CMakeLists.txt",
   "mongo/functional_tests/basic_chaos/mongo_service.cpp":"taxi/uservices/userver/mongo/functional_tests/basic_chaos/mongo_service.cpp",

mongo/dynamic_configs/MONGO_DEADLINE_PROPAGATION_ENABLED_V2.yaml

@@ -0,0 +1,14 @@
+default: true
+description: |
+    When `false`, disables deadline propagation in the service. This includes:
+
+    - reading the task-inherited deadline from HTTP headers and gRPC metadata;
+    - interrupting operations when deadline expires;
+    - propagating the deadline to downstream services and databases.
+
+    Deadline propagation can also be disabled in the static config of:
+    - components::Server (disables the HTTP handler part).
+
+    Deadline propagation is disabled if disabled statically OR dynamically.
+schema:
+    type: boolean

mongo/dynamic_configs/USERVER_DEADLINE_PROPAGATION_ENABLED.yaml

@@ -14,7 +14,7 @@ async def _put_foo_value(service_client):
 
 
 async def test_works(service_client, put_foo_value, dynamic_config):
-    assert dynamic_config.get('MONGO_DEADLINE_PROPAGATION_ENABLED_V2')
+    assert dynamic_config.get('USERVER_DEADLINE_PROPAGATION_ENABLED')
 
     async with service_client.capture_logs() as capture:
         response = await service_client.get(
@@ -29,20 +29,3 @@ async def test_works(service_client, put_foo_value, dynamic_config):
     text = logs[0]['text']
     assert 'Operation cancelled: deadline propagation' in text, text
     assert 'storages::mongo::CancelledException' in text, text
-
-
-@pytest.mark.config(MONGO_DEADLINE_PROPAGATION_ENABLED_V2=False)
-async def test_disabled(service_client, put_foo_value, dynamic_config):
-    async with service_client.capture_logs() as capture:
-        response = await service_client.get(
-            '/v1/key-value?key=foo&sleep_ms=200',
-            headers={DP_TIMEOUT_MS: '100'},
-        )
-        assert response.status == 498
-        assert response.text == 'Deadline expired'
-
-    # The mongo request should be completed ignoring the fact that
-    # deadline has already expired.
-    logs = capture.select(_type='response', meta_type='/v1/key-value')
-    assert len(logs) == 1, logs
-    assert logs[0].get('dp_original_body', None) == 'bar', str(logs)

mongo/functional_tests/basic_chaos/tests-deadline-propagation/test_deadline_propagation.py

@@ -14,5 +14,5 @@ configs:
       - MONGO_CONGESTION_CONTROL_ENABLED
       - MONGO_CONGESTION_CONTROL_SETTINGS
       - MONGO_CONNECTION_POOL_SETTINGS
-      - MONGO_DEADLINE_PROPAGATION_ENABLED_V2
+      - USERVER_DEADLINE_PROPAGATION_ENABLED
       - MONGO_DEFAULT_MAX_TIME_MS

mongo/library.yaml

@@ -22,8 +22,8 @@
 #include <storages/mongo/operations_common.hpp>
 #include <storages/mongo/operations_impl.hpp>
 
-#include <dynamic_config/variables/MONGO_DEADLINE_PROPAGATION_ENABLED_V2.hpp>
 #include <dynamic_config/variables/MONGO_DEFAULT_MAX_TIME_MS.hpp>
+#include <dynamic_config/variables/USERVER_DEADLINE_PROPAGATION_ENABLED.hpp>
 
 USERVER_NAMESPACE_BEGIN
 
@@ -105,7 +105,7 @@ impl::cdriver::FindAndModifyOptsPtr CopyFindAndModifyOptions(const impl::cdriver
 }
 
 std::optional<std::chrono::milliseconds> GetDeadlineTimeLeft(const dynamic_config::Snapshot& config) {
-    if (!config[::dynamic_config::MONGO_DEADLINE_PROPAGATION_ENABLED_V2]) return std::nullopt;
+    if (!config[::dynamic_config::USERVER_DEADLINE_PROPAGATION_ENABLED]) return std::nullopt;
 
     const auto inherited_deadline = server::request::GetTaskInheritedDeadline();
     if (!inherited_deadline.IsReachable()) return std::nullopt;

mongo/src/storages/mongo/cdriver/collection_impl.cpp

@@ -25,7 +25,7 @@
 #include <userver/storages/mongo/exception.hpp>
 #include <userver/storages/mongo/mongo_error.hpp>
 
-#include <dynamic_config/variables/MONGO_DEADLINE_PROPAGATION_ENABLED_V2.hpp>
+#include <dynamic_config/variables/USERVER_DEADLINE_PROPAGATION_ENABLED.hpp>
 
 USERVER_NAMESPACE_BEGIN
 
@@ -454,7 +454,7 @@ CDriverPoolImpl::ConnPtr CDriverPoolImpl::Pop() {
     std::optional<engine::Deadline::Duration> inherited_timeout{};
 
     const auto dynamic_config = GetConfig();
-    if (dynamic_config[::dynamic_config::MONGO_DEADLINE_PROPAGATION_ENABLED_V2]) {
+    if (dynamic_config[::dynamic_config::USERVER_DEADLINE_PROPAGATION_ENABLED]) {
         HandleCancellations(queue_deadline, inherited_timeout);
     }
 

mongo/src/storages/mongo/cdriver/pool_impl.cpp

@@ -2,8 +2,8 @@ default: {}
 description: |
     Dynamic config that controls connection pool settings of PostgreSQL driver.
 
-    Dictionary keys can be either the service **component name** (not database name!)
-    or `__default__`. The latter configuration is applied for every non-matching
+    Dictionary keys can be either the value of `name_alias` static configuration option of the PostgreSQL component
+    (**not database name!**) or `__default__`. The latter configuration is applied for every non-matching
     PostgreSQL component of the service.
 
     Take note that it overrides the static configuration values of the service!
@@ -41,19 +41,30 @@ schema:
                     minimum: 0
                     default: 4
                     x-usrv-cpp-type: std::size_t
+                    description: |
+                        Number of connections created initially by PostgreSQL component instance to each of the provided
+                        PostgreSQL hosts. Connections are kept even without requests.
                 max_pool_size:
                     type: integer
                     minimum: 1
                     default: 15
                     x-usrv-cpp-type: std::size_t
+                    description: |
+                        Maximum number of connections that can be created by PostgreSQL component instance to each of
+                        the provided hosts for "connlimit_mode: manual". Should not be less than `min_pool_size`.
                 max_queue_size:
                     type: integer
                     minimum: 1
                     default: 200
+                    description: |
+                        Maximum number of clients waiting for a connection. Exception is thrown if a new request
+                        exceeds this limit.
                 connecting_limit:
                     type: integer
                     minimum: 0
                     default: 0
+                    description: |
+                        Limit for concurrent establishing connections number per PostgreSQL host (0 - unlimited).
             required:
               - min_pool_size
               - max_pool_size

postgresql/dynamic_configs/POSTGRES_CONNECTION_POOL_SETTINGS.yaml

@@ -3,8 +3,8 @@ description: |
     Dynamic config that controls settings for newly created connections of
     PostgreSQL driver.
 
-    Dictionary keys can be either the service **component name** (not database name!)
-    or `__default__`. The latter configuration is applied for every non-matching
+    Dictionary keys can be either the value of `name_alias` static configuration option of the PostgreSQL component
+    (**not database name!**) or `__default__`. The latter configuration is applied for every non-matching
     PostgreSQL component of the service.
 
     Take note that it overrides the static configuration values of the service!

postgresql/dynamic_configs/POSTGRES_CONNECTION_SETTINGS.yaml

@@ -2,8 +2,8 @@ default: {}
 description: |
     Dynamic config that controls statement metrics settings for specific service.
 
-    Dictionary keys can be either the service **component name** (not database name!)
-    or `__default__`. The latter configuration is applied for every non-matching
+    Dictionary keys can be either the value of `name_alias` static configuration option of the PostgreSQL component
+    (**not database name!**) or `__default__`. The latter configuration is applied for every non-matching
     PostgreSQL component of the service.
 
     The value of `max_statement_metrics` controls the maximum size of LRU-cache