Clearing diagnostics of transient files after a close event by mimicking a delete (#902)

* Clearing diagnostics of transient files after a close event by mimicking a delete

* Fixed member name

* Clearing diagnostics of transient Rascal files after a close event by mimicking a delete

* Restored debug print

---------

Co-authored-by: Davy Landman <[email protected]>

Author: rodinaarssen

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java

@@ -75,6 +75,7 @@
 import org.eclipse.lsp4j.DocumentSymbol;
 import org.eclipse.lsp4j.DocumentSymbolParams;
 import org.eclipse.lsp4j.ExecuteCommandOptions;
+import org.eclipse.lsp4j.FileDelete;
 import org.eclipse.lsp4j.FileRename;
 import org.eclipse.lsp4j.FoldingRange;
 import org.eclipse.lsp4j.FoldingRangeRequestParams;
@@ -335,14 +336,21 @@ public void didClose(DidCloseTextDocumentParams params) {
             throw new ResponseErrorException(unknownFileError(loc, params));
         }
         facts(loc).close(loc);
+        exec.execute(() -> {
+            // If the closed file no longer exists (e.g., if an untitled file is closed without ever having been saved),
+            // we mimic a delete event to ensure all diagnostics are cleared.
+            if (!URIResolverRegistry.getInstance().exists(loc)) {
+                didDeleteFiles(new DeleteFilesParams(List.of(new FileDelete(params.getTextDocument().getUri()))));
+            }
+        });
     }
 
     @Override
     public void didDeleteFiles(DeleteFilesParams params) {
         exec.submit(() -> {
             // if a file is deleted, and we were tracking it, we remove our diagnostics
             for (var f : params.getFiles()) {
-                if (isLanguageRegistered(URIUtil.assumeCorrectLocation(f.getUri()))) {
+                if (isLanguageRegistered(Locations.toLoc(f.getUri()))) {
                     availableClient().publishDiagnostics(new PublishDiagnosticsParams(f.getUri(), List.of()));
                 }
             }

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/rascal/RascalTextDocumentService.java

@@ -65,6 +65,7 @@
 import org.eclipse.lsp4j.DocumentSymbolParams;
 import org.eclipse.lsp4j.ExecuteCommandOptions;
 import org.eclipse.lsp4j.FileCreate;
+import org.eclipse.lsp4j.FileDelete;
 import org.eclipse.lsp4j.FoldingRange;
 import org.eclipse.lsp4j.FoldingRangeRequestParams;
 import org.eclipse.lsp4j.Hover;
@@ -283,10 +284,17 @@ public void didChange(DidChangeTextDocumentParams params) {
     @Override
     public void didClose(DidCloseTextDocumentParams params) {
         logger.debug("Close: {}", params.getTextDocument());
-        if (documents.remove(Locations.toLoc(params.getTextDocument())) == null) {
-            throw new ResponseErrorException(new ResponseError(ResponseErrorCode.InternalError,
-                "Unknown file: " + Locations.toLoc(params.getTextDocument()), params));
+        var loc = Locations.toLoc(params.getTextDocument());
+        if (documents.remove(loc) == null) {
+            throw new ResponseErrorException(new ResponseError(ResponseErrorCode.InternalError, "Unknown file: " + loc, params));
         }
+        exec.execute(() -> {
+            // If the closed file no longer exists (e.g., if an untitled file is closed without ever having been saved),
+            // we mimic a delete event to ensure all diagnostics are cleared.
+            if (!URIResolverRegistry.getInstance().exists(loc)) {
+                didDeleteFiles(new DeleteFilesParams(List.of(new FileDelete(params.getTextDocument().getUri()))));
+            }
+        });
     }
 
     @Override