Skip to content

Commit d8da3e8

Browse files
authored
Reduce duplicate contributions in multiplexer. (#928)
1 parent bb4d293 commit d8da3e8

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/LanguageContributionsMultiplexer.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,10 @@ private static final <T> CompletableFuture<T> failedInitialization() {
6767
private volatile CompletableFuture<ILanguageContributions> references = failedInitialization();
6868
private volatile CompletableFuture<ILanguageContributions> implementation = failedInitialization();
6969
private volatile CompletableFuture<ILanguageContributions> codeAction = failedInitialization();
70-
private volatile CompletableFuture<ILanguageContributions> prepareRename = failedInitialization();
7170
private volatile CompletableFuture<ILanguageContributions> rename = failedInitialization();
7271
private volatile CompletableFuture<ILanguageContributions> didRenameFiles = failedInitialization();
7372
private volatile CompletableFuture<ILanguageContributions> selectionRange = failedInitialization();
74-
private volatile CompletableFuture<ILanguageContributions> prepareCallHierarchy = failedInitialization();
75-
private volatile CompletableFuture<ILanguageContributions> incomingOutgoingCalls = failedInitialization();
73+
private volatile CompletableFuture<ILanguageContributions> callHierarchy = failedInitialization();
7674

7775
private volatile CompletableFuture<Boolean> hasAnalysis = failedInitialization();
7876
private volatile CompletableFuture<Boolean> hasBuild = failedInitialization();
@@ -163,11 +161,9 @@ private synchronized void calculateRouting() {
163161
implementation = findFirstOrDefault(ILanguageContributions::hasImplementation);
164162
codeAction = findFirstOrDefault(ILanguageContributions::hasCodeAction);
165163
rename = findFirstOrDefault(ILanguageContributions::hasRename);
166-
prepareRename = findFirstOrDefault(ILanguageContributions::hasRename);
167164
didRenameFiles = findFirstOrDefault(ILanguageContributions::hasDidRenameFiles);
168165
selectionRange = findFirstOrDefault(ILanguageContributions::hasSelectionRange);
169-
prepareCallHierarchy = findFirstOrDefault(ILanguageContributions::hasCallHierarchy);
170-
incomingOutgoingCalls = findFirstOrDefault(ILanguageContributions::hasCallHierarchy);
166+
callHierarchy = findFirstOrDefault(ILanguageContributions::hasCallHierarchy);
171167

172168
hasAnalysis = anyTrue(ILanguageContributions::hasAnalysis);
173169
hasBuild = anyTrue(ILanguageContributions::hasBuild);
@@ -291,7 +287,7 @@ public CompletableFuture<IList> parseCodeActions(String command) {
291287

292288
@Override
293289
public CompletableFuture<IConstructor> parseCallHierarchyData(String data) {
294-
return incomingOutgoingCalls.thenApply(c -> c.parseCallHierarchyData(data)).thenCompose(Function.identity());
290+
return callHierarchy.thenApply(c -> c.parseCallHierarchyData(data)).thenCompose(Function.identity());
295291
}
296292

297293
@Override
@@ -301,7 +297,7 @@ public InterruptibleFuture<IList> inlayHint(ITree input) {
301297

302298
@Override
303299
public InterruptibleFuture<ISourceLocation> prepareRename(IList focus) {
304-
return flatten(prepareRename, c -> c.prepareRename(focus));
300+
return flatten(rename, c -> c.prepareRename(focus));
305301
}
306302

307303
@Override
@@ -351,12 +347,12 @@ public InterruptibleFuture<IList> selectionRange(IList focus) {
351347

352348
@Override
353349
public InterruptibleFuture<IList> prepareCallHierarchy(IList focus) {
354-
return flatten(prepareCallHierarchy, c -> c.prepareCallHierarchy(focus));
350+
return flatten(callHierarchy, c -> c.prepareCallHierarchy(focus));
355351
}
356352

357353
@Override
358354
public InterruptibleFuture<IList> incomingOutgoingCalls(IConstructor hierarchyItem, IConstructor direction) {
359-
return flatten(incomingOutgoingCalls, c -> c.incomingOutgoingCalls(hierarchyItem, direction));
355+
return flatten(callHierarchy, c -> c.incomingOutgoingCalls(hierarchyItem, direction));
360356
}
361357

362358
@Override

0 commit comments

Comments
 (0)