Fix compatibility with 4.93 and HSL IO v0.3

Author: fredemmott

.hhconfig

@@ -7,7 +7,6 @@ disable_halt_compiler = true
 disable_instanceof_refinement = true
 disable_legacy_soft_typehints = true
 disable_lval_as_an_expression = true
-disable_partially_abstract_typeconsts = true
 disable_primitive_refinement = true
 disable_static_closures = true
 disable_static_local_variables = true
@@ -39,3 +38,4 @@ typecheck_xhp_cvars = true
 unsafe_rx = false
 allowed_decl_fixme_codes=2053,4047
 allowed_fixme_codes_strict=2011,2049,2050,2053,4026,4027,4047,4053,4104,4107,4108,4110,4128,4135,4188,4200,4240,4248,4323
+ignored_paths = [ "vendor/.+/tests/.+" ]

composer.json

@@ -13,11 +13,11 @@
 		}
 	],
 	"require": {
-		"hhvm": "^4.58",
+		"hhvm": "^4.93",
 		"facebook/hack-http-request-response-interfaces": "^0.3",
 		"hhvm/hsl": "^4.25",
 		"hhvm/hsl-experimental": "^4.58",
-		"hhvm/hsl-io": "^0.2.1",
+		"hhvm/hsl-io": "^0.3.0",
 		"hhvm/type-assert": "^3.3|^4.0",
 		"usox/hack-http-factory-interfaces": "^0.2"
 	},

example/index.hack

@@ -9,7 +9,7 @@ async function main(): Awaitable<noreturn> {
 
   $response = $response->withAddedHeaderLine('X-ZOMG', 'aggi');
 
-  await $response->getBody()->writeAsync('foo');
+  await $response->getBody()->writeAllAsync('foo');
 
   $emitter = new \Usox\HackTTP\Response\TemporaryFileSapiEmitter();
   await $emitter->emitAsync($response);

src/UploadedFile.hack

@@ -57,12 +57,13 @@ final class UploadedFile implements Message\UploadedFileInterface {
     // peak memory usage
     do {
       /* HHAST_IGNORE_ERROR[DontAwaitInALoop] */
-      $chunk = await $this->stream->readAsync();
+      $chunk = await $this->stream->readAllowPartialSuccessAsync();
       if ($chunk === '') {
         break;
       }
+      // ... but we need to write everything we read, so writeAllAsync
       /* HHAST_IGNORE_ERROR[DontAwaitInALoop] */
-      await $target->writeAsync($chunk);
+      await $target->writeAllAsync($chunk);
     } while (true);
 
     if ($this->stream is IO\CloseableHandle) {