Support (and require) hsl-experimental 4.52

Upstream changes:
- blocking functions renamed
- readAsync/writeAsync no longer deal with the whole thing

Other changes made here:

- do a chunked copy instead of using readAll/writeAll to reduce peak
  memory
- that means we're making multiple calls with different return values,
  which I don't see how to mock. Use a pipe handle instead of a
  mock in the unit test.

Author: fredemmott

composer.json

@@ -13,10 +13,10 @@
 		}
 	],
 	"require": {
-		"hhvm": "^4.1",
+		"hhvm": "^4.52",
 		"facebook/hack-http-request-response-interfaces": "^0.3",
 		"hhvm/hsl": "^4.25",
-		"hhvm/hsl-experimental": "^4.50",
+		"hhvm/hsl-experimental": "^4.52",
 		"hhvm/type-assert": "^3.3",
 		"usox/hack-http-factory-interfaces": "^0.2"
 	},

src/UploadedFile.hack

@@ -52,7 +52,17 @@ final class UploadedFile implements Message\UploadedFileInterface {
 
   private async function writeAsync(string $target_path): Awaitable<void> {
     await using $target = File\open_write_only($target_path);
-    await $target->writeAsync($this->stream->rawReadBlocking());
+    // Doing this a chunk at a time instead of using `readAllAsync()` to reduce
+    // peak memory usage
+    do {
+      /* HHAST_IGNORE_ERROR[DontAwaitInALoop] */
+      $chunk = await $this->stream->readAsync();
+      if ($chunk === '') {
+        break;
+      }
+      /* HHAST_IGNORE_ERROR[DontAwaitInALoop] */
+      await $target->writeAsync($chunk);
+    } while (true);
     if ($this->stream is IO\CloseableHandle) {
       await $this->stream->closeAsync();
     }

tests/UploadedFileTest.hack

@@ -10,7 +10,7 @@
 namespace Usox\HackTTP;
 
 use namespace Facebook\Experimental\Http\Message;
-use namespace HH\Lib\{File, IO};
+use namespace HH\Lib\{File, IO, OS};
 use type Facebook\HackTest\HackTest;
 use function Facebook\FBExpect\expect;
 use function Usox\HackMock\{mock, prospect};
@@ -85,28 +85,27 @@ class UploadedFileTest extends HackTest {
       );
   }
 
-  public function testMoveToMovesFile(): void {
+  public async function testMoveToMovesFile(): Awaitable<void> {
     $filename = \sys_get_temp_dir().'/'.\bin2hex(\random_bytes(16));
     $content = 'some-content';
-    $read_handle = mock(IO\ReadHandle::class);
-
-    prospect($read_handle, 'rawReadBlocking')
-      ->with(null)
-      ->once()
-      ->andReturn($content);
-    prospect($read_handle, 'closeAsync')
-      ->once();
+    list($read_handle, $write_handle) = IO\pipe_nd();
+    $write_handle->write($content);
+    await $write_handle->closeAsync();
 
     $file = new UploadedFile(
       $read_handle,
       666
     );
 
     $file->moveTo($filename);
+    $ex = expect(async () ==> await $read_handle->closeAsync())->toThrow(
+      OS\ErrnoException::class,
+    );
+    expect($ex->getErrno())->toEqual(OS\Errno::EBADF);
 
     $target_file = File\open_read_only_nd($filename);
 
-    expect($target_file->rawReadBlocking())
+    expect($target_file->read())
       ->toBeSame($content);
 
     // after moving the file, the readhandle becomes invalid