updated tests / documentation

Author: usrbinr

DESCRIPTION

@@ -24,7 +24,8 @@ Imports:
     cli,
     duckdb (>= 1.4.0)
 Suggests:
-    testthat (>= 3.0.0)
+    testthat (>= 3.0.0),
+    dbplyr
 Encoding: UTF-8
 LazyData: true
 RoxygenNote: 7.3.3

NEWS.md

@@ -1,4 +1,6 @@
 # contoso 1.2.1
+* fixed create_contoso_duckdb() due to error created by table name changed
+* updated tests 
 
 # contoso 1.2.0
 * changed 'date' table name to 'calendar' to avoid namespace conflicts with lubridate and base packages

cran-comments.md

@@ -1,4 +1,6 @@
 ## R CMD check results
 
-0 errors ✔ | 0 warnings ✔ | 0 notes ✔
-* updated table name to avoid namespace conflicts with popular packages
+0 errors ✔ | 0 warnings ✔ | 1 note ✖
+* Days since last update: 1
+
+* fixed error in function caused by table name change

tests/testthat/test-create_duckdb_database.R

@@ -2,21 +2,25 @@
 
 describe("create_contoso_duckdb()", {
 
+    it("creates a DuckDB database containing all expected tables", {
 
-        skip_if_not_installed("DBI")
-        skip_if_not_installed("duckdb")
-        skip_if_not_installed("dplyr")
-        skip_if_not_installed("dbplyr")
-        skip_on_cran()
-        skip_on_ci()
 
-        result <- create_contoso_duckdb(db_dir = "in_memory", size = "100K")
+        # Create a small in-memory Contoso DuckDB instance
+        result <- create_contoso_duckdb(
+            db_dir = "in_memory",
+            size   = "100K"
+        )
 
-        expected_names <- c("sales","product","customer","store","fx","date","orders","orderrows")
+        # List of tables that should be present in the returned list / connection object
+        expected_names <- c(
+            "sales", "product", "customer", "store", "fx",
+            "calendar", "orders", "orderrows", "con"
+        )
 
+        # Verify all expected tables exist
         expect_true(all(expected_names %in% names(result)))
-        expect_setequal(names(result), expected_names)
-
-        expect_true(all(vapply(result, inherits, logical(1), what = "tbl_lazy")))
 
+        # Verify no unexpected tables are present
+        expect_setequal(names(result), expected_names)
     })
+})