Skip to content

Commit 3bc682f

Browse files
authored
feat: sort meta by name in asc order (#57)
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
1 parent baf51b9 commit 3bc682f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

pkg/server/meta_handlers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ func (s *Server) handlerListRepoMetas(c echo.Context) error {
1414
l.Debug("Invoked")
1515

1616
var metas []model.RepoMeta
17-
err := s.getDB(c).Find(&metas).Error
17+
err := s.getDB(c).Order("name").Find(&metas).Error
1818
if err != nil {
1919
const msg = "Fail to list RepoMetas"
2020
l.Error(msg, slogErrAttr(err))

pkg/server/meta_handlers_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ func TestHandlerListRepoMetas(t *testing.T) {
1313
te := NewTestEnv(t)
1414
require.NoError(t, te.server.db.Create([]model.RepoMeta{
1515
{
16-
Name: t.Name(),
16+
Name: "repo2",
17+
},
18+
{
19+
Name: "repo1",
1720
},
1821
}).Error)
1922

@@ -23,8 +26,8 @@ func TestHandlerListRepoMetas(t *testing.T) {
2326
require.NoError(t, err)
2427
require.True(t, resp.IsSuccess(), "Unexpected response: %s", resp.Body())
2528

26-
require.Len(t, metas, 1)
27-
require.EqualValues(t, t.Name(), metas[0].Name)
29+
require.Len(t, metas, 2)
30+
require.EqualValues(t, "repo1", metas[0].Name)
2831
}
2932

3033
func TestHandlerGetRepoMeta(t *testing.T) {

0 commit comments

Comments
 (0)