fix if env var is url caontining mutiple = signs

Author: kamil-stc

pkg/vault/credentials.go

@@ -39,7 +39,7 @@ func (c *Credentials) EnvVars() map[string]string {
 	envMap := make(map[string]string)
 
 	for _, v := range os.Environ() {
-		splitEnv := strings.Split(v, "=")
+		splitEnv := strings.SplitN(v, "=", 2)
 		envMap[splitEnv[0]] = splitEnv[1]
 	}
 

pkg/vault/credentials_test.go

@@ -1,6 +1,8 @@
 package vault
 
 import (
+	"maps"
+	"os"
 	"testing"
 
 	"github.com/hashicorp/vault/api"
@@ -27,3 +29,36 @@ func TestCredentials(t *testing.T) {
 	}
 
 }
+
+func TestEnvVars(t *testing.T) {
+	c := Credentials{
+		Username: "user",
+		Password: "passwd",
+	}
+	input := map[string]string{
+		"DB_URL":             "http://localhost:9001",
+		"DB_URL_PARAMS":      "http://localhost:9001?sslmode=force",
+		"DB_URL_MORE_PARAMS": "http://localhost:9001?sslmode=force&param1=val1&par2=something",
+	}
+	expected_output := map[string]string{
+		"Username": c.Username,
+		"Password": c.Password,
+	}
+
+	maps.Copy(expected_output, input)
+	os.Clearenv()
+	for k, v := range input {
+		defer os.Unsetenv(k)
+		err := os.Setenv(k, v)
+		if err != nil {
+			t.Error(err)
+		}
+	}
+
+	result := c.EnvVars()
+
+	if !maps.Equal(expected_output, result) {
+		t.Errorf("Result: %v is not equalt to expected result: %v", result, expected_output)
+	}
+
+}