Skip to content

Opcodes CHAINID and SELFBALANCE added#65

Open
gsalzer wants to merge 2 commits intousyd-blockchain:masterfrom
gsalzer:master
Open

Opcodes CHAINID and SELFBALANCE added#65
gsalzer wants to merge 2 commits intousyd-blockchain:masterfrom
gsalzer:master

Conversation

@gsalzer
Copy link
Contributor

@gsalzer gsalzer commented Jul 29, 2021

No description provided.

@gsalzer gsalzer requested a review from a team as a code owner July 29, 2021 13:06
b-scholz
b-scholz previously approved these changes Jul 29, 2021
Copy link

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

Copy link

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the op-code.

@faustocarva
Copy link

Can we merge this?

@gsalzer
Copy link
Contributor Author

gsalzer commented Dec 21, 2023

Unfortunately, this is only a superficial extension, which makes the new opcodes known to some parts of the analysis, but does not tell Vandal their semantics. I liked to use Vandal's disassembler, and for that, the extension of opcodes.py is sufficient. Those parts of Vandal that perform the static analysis may need to know more about the instructions than just their effect on the stack. One may at least have to check that after processing one of the new instructions, Vandal's assumptions about the EVM state afterwards are still valid.

@faustocarva
Copy link

Ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments