fix test

Author: aster-void

server/prisma/sql/recommend.sql

@@ -1,6 +1,6 @@
 -- $1 = senderId
 SELECT
-    recv, 
+    *, 
     -- course overlap
     (SELECT COUNT(1) FROM "Course" course
         WHERE EXISTS (SELECT 1 FROM "Enrollment" e WHERE e."courseId" = course.id AND e."userId" = recv.id)

server/src/functions/engines/recommendation.test.ts

@@ -8,14 +8,14 @@ beforeAll(() => {
 
 test("recommendation engine", async () => {
   const usersFor101 = await recommendedTo(101, 5, 0);
-  if (!usersFor101.ok) throw new Error();
+  if (!usersFor101.ok) throw console.error(usersFor101.error);
   expect(usersFor101.value.map((entry) => entry.u.id)).toEqual([102, 103]);
 
   const usersFor102 = await recommendedTo(102, 5, 0);
-  if (!usersFor102.ok) throw new Error();
+  if (!usersFor102.ok) throw console.error(usersFor102.error);
   expect(usersFor102.value.map((entry) => entry.u.id)).toEqual([103, 101]);
 
   const usersFor103 = await recommendedTo(103, 5, 0);
-  if (!usersFor103.ok) throw new Error();
+  if (!usersFor103.ok) throw console.error(usersFor103.error);
   expect(usersFor103.value.map((entry) => entry.u.id)).toEqual([102, 101]);
 });

server/src/functions/engines/recommendation.ts

@@ -12,25 +12,23 @@ export async function recommendedTo(
   Result<
     Array<{
       u: UserWithCoursesAndSubjects;
-      count: number;
+      overlap: number;
     }>
   >
 > {
   try {
     const result = await prisma.$queryRawTyped(sql(user, limit, offset));
     return Promise.all(
       result.map(async (res) => {
-        const user = await getUserByID(res.id);
-        if (!user.ok) throw new Error("not found"); // this shouldn't happen
-        return {
-          count: Number.parseInt(res.overlap?.toString() ?? "0"),
-          u: user.value,
-        };
+        if (!res) throw new Error("res is null: something is wrong");
+        const { overlap: count, ...u } = res;
+        return { count, u };
       }),
     )
       .then((val) => Ok(val))
       .catch((err) => Err(err));
   } catch (err) {
-    return Err(err);
+    console.error("caught error: ", err);
+    return Err(500);
   }
 }