Merge pull request #49 from ut-code/fix-node-deletion

fix node deletion

Author: chelproc

src/pages/edit/Editor/store/index.tsx

@@ -177,7 +177,6 @@ function createEditorStore(componentId: CCComponentId, store: CCStore) {
       timeStep <= editorState.timeStep;
       timeStep += 1
     ) {
-      console.log(timeStep);
       const previousFrame = simulationCachedFrames[timeStep - 1] ?? null;
       const inputValues = new Map();
       const pins = store.componentPins.getManyByComponentId(componentId);

src/store/componentPin.ts

@@ -89,14 +89,24 @@ export class CCComponentPinStore extends EventEmitter<CCComponentPinStoreEvents>
       if (toComponentPin) this.unregister(toComponentPin.id);
     });
     this.#store.connections.on("willUnregister", (connection) => {
-      this.register(this.createForNodePin(connection.to));
+      if (
+        !this.#store.nodePins.isMarkedAsDeleted(connection.to) &&
+        this.#store.nodePins.get(connection.to)
+      ) {
+        this.register(this.createForNodePin(connection.to));
+      }
       // output pins can have multiple connections
       // so we need to check if the connection is the last one
       if (
         this.#store.connections.getConnectionsByNodePinId(connection.from)
           .length === 1
       ) {
-        this.register(this.createForNodePin(connection.from));
+        if (
+          !this.#store.nodePins.isMarkedAsDeleted(connection.from) &&
+          this.#store.nodePins.get(connection.from)
+        ) {
+          this.register(this.createForNodePin(connection.from));
+        }
       }
     });
   }

src/store/nodePin.ts

@@ -25,6 +25,8 @@ export class CCNodePinStore extends EventEmitter<CCNodePinStoreEvents> {
 
   #nodePins: Map<CCNodePinId, CCNodePin> = new Map();
 
+  #markedAsDeleted: Set<CCNodePinId> = new Set();
+
   /**
    * Constructor of CCNodePinStore
    * @param store store
@@ -100,11 +102,13 @@ export class CCNodePinStore extends EventEmitter<CCNodePinStoreEvents> {
    */
   async unregister(id: CCNodePinId): Promise<void> {
     const nodePin = nullthrows(this.#nodePins.get(id));
+    this.#markedAsDeleted.add(id);
     await this.#store.transactionManager.runInTransaction(() => {
       this.emit("willUnregister", nodePin);
       this.#nodePins.delete(nodePin.id);
     });
     this.emit("didUnregister", nodePin);
+    this.#markedAsDeleted.delete(id);
   }
 
   /**
@@ -195,6 +199,10 @@ export class CCNodePinStore extends EventEmitter<CCNodePinStoreEvents> {
     return traverseNodePinMultiplexability(nodePinId, new Set());
   }
 
+  isMarkedAsDeleted(id: CCNodePinId) {
+    return this.#markedAsDeleted.has(id);
+  }
+
   /**
    * Create a new pin
    * @param partialPin pin without `id`