Address code review feedback - fix interrupt buffer and error handling

Co-authored-by: na-trium-144 <100704180+na-trium-144@users.noreply.github.com>

Author: Copilot

app/terminal/ruby/runtime.tsx

@@ -63,7 +63,6 @@ export function RubyProvider({ children }: { children: ReactNode }) {
     Map<number, [(payload: any) => void, (error: string) => void]>
   >(new Map());
   const nextMessageId = useRef<number>(0);
-  const interruptBuffer = useRef<Uint8Array | null>(null);
 
   function postMessage<T>({ type, payload }: MessageToWorker) {
     const id = nextMessageId.current++;
@@ -109,9 +108,9 @@ export function RubyProvider({ children }: { children: ReactNode }) {
   }, []);
 
   const interrupt = useCallback(() => {
-    if (interruptBuffer.current) {
-      interruptBuffer.current[0] = 2;
-    }
+    // TODO: Implement interrupt functionality for Ruby
+    // Ruby WASM doesn't currently support interrupts like Pyodide does
+    console.warn("Ruby interrupt is not yet implemented");
   }, []);
 
   const runCommand = useCallback(
@@ -123,10 +122,6 @@ export function RubyProvider({ children }: { children: ReactNode }) {
         return [{ type: "error", message: "Ruby VM is not ready yet." }];
       }
 
-      if (interruptBuffer.current) {
-        interruptBuffer.current[0] = 0;
-      }
-
       const { output, updatedFiles } = await postMessage<RunPayloadFromWorker>({
         type: "runRuby",
         payload: { code },
@@ -166,9 +161,6 @@ export function RubyProvider({ children }: { children: ReactNode }) {
       if (!workerRef.current || !ready) {
         return [{ type: "error", message: "Ruby VM is not ready yet." }];
       }
-      if (interruptBuffer.current) {
-        interruptBuffer.current[0] = 0;
-      }
       return mutex.current.runExclusive(async () => {
         const { output, updatedFiles } =
           await postMessage<RunPayloadFromWorker>({

public/ruby.worker.js

@@ -109,15 +109,37 @@ function flushOutput() {
     }
     stderrBuffer = lines[lines.length - 1];
   }
-  // Final flush if there's remaining text
-  if (stdoutBuffer) {
+  // Final flush if there's remaining non-empty text
+  if (stdoutBuffer && stdoutBuffer.trim()) {
     rubyOutput.push({ type: 'stdout', message: stdoutBuffer });
-    stdoutBuffer = "";
   }
-  if (stderrBuffer) {
+  stdoutBuffer = "";
+  
+  if (stderrBuffer && stderrBuffer.trim()) {
     rubyOutput.push({ type: 'stderr', message: stderrBuffer });
-    stderrBuffer = "";
   }
+  stderrBuffer = "";
+}
+
+function formatRubyError(error) {
+  if (!(error instanceof Error)) {
+    return `予期せぬエラー: ${String(error).trim()}`;
+  }
+  
+  let errorMessage = error.message;
+  
+  // Clean up Ruby error messages by filtering out internal eval lines
+  if (errorMessage.includes('Traceback') || errorMessage.includes('Error')) {
+    const lines = errorMessage.split('\n');
+    // Keep lines that either don't contain (eval), or contain Error, or have line numbers
+    errorMessage = lines.filter(line => 
+      !line.includes('(eval)') || 
+      line.includes('Error') || 
+      line.match(/:\d+:/)
+    ).join('\n').trim();
+  }
+  
+  return errorMessage;
 }
 
 async function runRuby(id, payload) {
@@ -151,30 +173,10 @@ async function runRuby(id, payload) {
     console.log(e);
     flushOutput();
 
-    if (e instanceof Error) {
-      let errorMessage = e.message;
-      
-      // Clean up Ruby error messages
-      if (errorMessage.includes('Traceback') || errorMessage.includes('Error')) {
-        const lines = errorMessage.split('\n');
-        // Filter out internal lines
-        errorMessage = lines.filter(line => 
-          !line.includes('(eval)') || 
-          line.includes('Error') || 
-          line.match(/:\d+:/)
-        ).join('\n').trim();
-      }
-      
-      rubyOutput.push({
-        type: 'error',
-        message: errorMessage
-      });
-    } else {
-      rubyOutput.push({
-        type: 'error',
-        message: `予期せぬエラー: ${String(e).trim()}`
-      });
-    }
+    rubyOutput.push({
+      type: 'error',
+      message: formatRubyError(e)
+    });
   }
 
   const updatedFiles = readAllFiles();
@@ -222,28 +224,10 @@ async function runFile(id, payload) {
     console.log(e);
     flushOutput();
 
-    if (e instanceof Error) {
-      let errorMessage = e.message;
-      
-      if (errorMessage.includes('Traceback') || errorMessage.includes('Error')) {
-        const lines = errorMessage.split('\n');
-        errorMessage = lines.filter(line => 
-          !line.includes('(eval)') || 
-          line.includes('Error') || 
-          line.match(/:\d+:/)
-        ).join('\n').trim();
-      }
-      
-      rubyOutput.push({
-        type: 'error',
-        message: errorMessage
-      });
-    } else {
-      rubyOutput.push({
-        type: 'error',
-        message: `予期せぬエラー: ${String(e).trim()}`
-      });
-    }
+    rubyOutput.push({
+      type: 'error',
+      message: formatRubyError(e)
+    });
   }
 
   const updatedFiles = readAllFiles();