Skip to content

Commit d16de35

Browse files
Copilotna-trium-144
andcommitted
Simplify trackPromise using Promise.finally() and fix ESLint
- Refactor trackPromise to use .finally() for cleaner code - Add argsIgnorePattern and varsIgnorePattern to ESLint config - Allow underscore-prefixed unused parameters (convention) - Improve code readability and maintainability Co-authored-by: na-trium-144 <[email protected]>
1 parent 7c5a3e6 commit d16de35

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

app/terminal/worker/runtime.tsx

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,10 @@ export function WorkerProvider({
108108
pendingPromises.current.add(reject);
109109

110110
promise
111-
.then((result) => {
112-
// Remove reject function on success
111+
.then(resolve, reject)
112+
.finally(() => {
113+
// Remove reject function after promise settles
113114
pendingPromises.current.delete(reject);
114-
resolve(result);
115-
})
116-
.catch((error) => {
117-
// Remove reject function on error
118-
pendingPromises.current.delete(reject);
119-
reject(error);
120115
});
121116
});
122117
},

eslint.config.mjs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ const eslintConfig = [
2020
vars: "all",
2121
args: "after-used",
2222
ignoreRestSiblings: true,
23+
argsIgnorePattern: "^_",
24+
varsIgnorePattern: "^_",
2325
},
2426
],
2527
},

0 commit comments

Comments
 (0)