Exit with error on client exceptions

Author: viniciusam

src/main/java/io/github/utplsql/cli/Cli.java

@@ -6,6 +6,8 @@
 
 public class Cli {
 
+    public static final int DEFAULT_ERROR_CODE = 1;
+
     public static final String HELP_CMD = "-h";
     public static final String RUN_CMD = "run";
 
@@ -15,15 +17,15 @@ public static void main(String[] args) {
         RunCommand runCmd = new RunCommand();
         jc.addCommand(RUN_CMD, runCmd);
 
+        int exitCode = DEFAULT_ERROR_CODE;
+
         try {
             jc.parse(args);
-            boolean hasCmd = jc.getParsedCommand() != null;
 
-            if (hasCmd && jc.getParsedCommand().equals(RUN_CMD)) {
-                int status = runCmd.run();
-                System.exit(status);
+            if (RUN_CMD.equals(jc.getParsedCommand())) {
+                exitCode = runCmd.run();
             } else {
-                jc.usage();
+                throw new ParameterException("Command not specified.");
             }
         } catch (ParameterException e) {
             if (jc.getParsedCommand() != null) {
@@ -35,6 +37,8 @@ public static void main(String[] args) {
         } catch (Exception e) {
             e.printStackTrace();
         }
+
+        System.exit(exitCode);
     }
 
     private static class HelpCommand {

src/main/java/io/github/utplsql/cli/RunCommand.java

@@ -130,8 +130,8 @@ public int run() throws Exception {
                 reporterList.add(reporter);
             }
         } catch (SQLException e) {
-            // TODO
-            e.printStackTrace();
+            System.out.println(e.getMessage());
+            return Cli.DEFAULT_ERROR_CODE;
         }
 
         ExecutorService executorService = Executors.newFixedThreadPool(1 + reporterList.size());
@@ -150,8 +150,8 @@ public int run() throws Exception {
             } catch (SomeTestsFailedException e) {
                 returnCode[0] = this.failureExitCode;
             } catch (SQLException e) {
-                // TODO
-                e.printStackTrace();
+                System.out.println(e.getMessage());
+                returnCode[0] = Cli.DEFAULT_ERROR_CODE;
             }
         });
 
@@ -173,8 +173,8 @@ public int run() throws Exception {
 
                     new OutputBuffer(ro.getReporterObj()).printAvailable(conn, printStreams);
                 } catch (SQLException | FileNotFoundException e) {
-                    // TODO
-                    e.printStackTrace();
+                    System.out.println(e.getMessage());
+                    returnCode[0] = Cli.DEFAULT_ERROR_CODE;
                 } finally {
                     if (fileOutStream != null)
                         fileOutStream.close();