Add functionality to ignore null or empty adds

Author: pesse

src/main/java/org/utplsql/api/db/DynamicParameterList.java

@@ -10,7 +10,7 @@
 
 public class DynamicParameterList {
 
-    LinkedHashMap<String, DynamicParameter> params;
+    private LinkedHashMap<String, DynamicParameter> params;
 
     interface DynamicParameter {
         void setParam( CallableStatement statement, int index ) throws SQLException;

src/main/java/org/utplsql/api/db/DynamicParameterListBuilder.java

@@ -19,15 +19,21 @@ public DynamicParameterListBuilder onlyAddIfNotEmpty() {
     }
 
     public DynamicParameterListBuilder add( String identifier, String value ) {
-        params.put(identifier, new DynamicParameterList.DynamicStringParameter(value));
+        if ( addIfNullOrEmpty || (value != null && !value.isEmpty()) ) {
+            params.put(identifier, new DynamicParameterList.DynamicStringParameter(value));
+        }
         return this;
     }
     public DynamicParameterListBuilder add( String identifier, Integer value ) {
-        params.put(identifier, new DynamicParameterList.DynamicIntegerParameter(value));
+        if ( addIfNullOrEmpty || (value != null)) {
+            params.put(identifier, new DynamicParameterList.DynamicIntegerParameter(value));
+        }
         return this;
     }
     public DynamicParameterListBuilder add(String identifier, Object[] value, String customTypeName, OracleConnection oraConnection ) {
-        params.put(identifier, new DynamicParameterList.DynamicArrayParameter(value, customTypeName, oraConnection));
+        if ( addIfNullOrEmpty || (value != null && value.length > 0 )) {
+            params.put(identifier, new DynamicParameterList.DynamicArrayParameter(value, customTypeName, oraConnection));
+        }
         return this;
     }
 

src/test/java/org/utplsql/api/db/DynamicParameterListTest.java

@@ -7,13 +7,12 @@
 import java.sql.SQLException;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.*;
 
 public class DynamicParameterListTest {
 
     @Test
-    void callWithThreeDifferentTypes() throws SQLException {
+    void call_with_three_different_types() throws SQLException {
 
         CallableStatement mockedStatement = mock(CallableStatement.class);
         OracleConnection mockedConn = mock(OracleConnection.class);
@@ -29,9 +28,31 @@ void callWithThreeDifferentTypes() throws SQLException {
         assertEquals("a_object_owner = ?, a_num_param = ?, a_num_array = ?", parameterList.getSql());
 
         parameterList.setParamsStartWithIndex(mockedStatement, 5);
+
         verify(mockedStatement).setString(5, "MyOwner");
         verify(mockedStatement).setInt(6, 123);
         verify(mockedConn).createOracleArray("MY_NUM_ARR", numArr);
         verify(mockedStatement).setArray(7, null);
     }
+
+    @Test
+    void when_not_accept_empty_filter_empty_elements() throws SQLException {
+
+        CallableStatement mockedStatement = mock(CallableStatement.class);
+        OracleConnection mockedConn = mock(OracleConnection.class);
+
+        DynamicParameterList parameterList = DynamicParameterListBuilder.create()
+                .onlyAddIfNotEmpty()
+                .add("a_object_owner", (String)null)
+                .add("a_num_param", (Integer)null)
+                .add("a_num_array", new Object[]{}, "MY_NUM_ARR", mockedConn)
+                .build();
+
+        assertEquals("", parameterList.getSql());
+
+        parameterList.setParamsStartWithIndex(mockedStatement, 2);
+
+        verifyNoMoreInteractions(mockedStatement);
+        verifyNoMoreInteractions(mockedConn);
+    }
 }