Skip to content

Commit 68cc533

Browse files
committed
update error message and added sorting
1 parent 37f5dd3 commit 68cc533

File tree

6 files changed

+63
-36
lines changed

6 files changed

+63
-36
lines changed

src/components/configmap/index.tsx

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,11 @@ const ConfigMapTab = (props: any) => {
1616
].filter(Boolean).join('&');
1717
try {
1818
const response = await httpRequest.get(`/api/deploy?${queryString}&loadConfig=true`);
19-
if (response && response.data.length) {
20-
saveConfigData(response.data);
21-
setConfigMapData(response.data);
22-
}
2319

2420
if (response && response.data && response.data.length > 0) {
2521
props.closeLoading(false);
22+
saveConfigData(response.data);
23+
setConfigMapData(response.data);
2624
}
2725
} catch (error: any) {
2826
setError(error.message);
@@ -42,7 +40,11 @@ const ConfigMapTab = (props: any) => {
4240
}
4341
}
4442

45-
saveConfigData(confData);
43+
const sortedDeployments = confData.map(group =>
44+
group.sort((a, b) => (a?.name ?? null).localeCompare(b?.name ?? null))
45+
);
46+
47+
saveConfigData(sortedDeployments);
4648
getConfigFromLocal();
4749
}
4850

@@ -64,24 +66,26 @@ const ConfigMapTab = (props: any) => {
6466
<div>
6567
<div> {error ? error : ""}</div>
6668
<div className="flex flex-row p-2 gap-8">
67-
{
68-
configMapData?.map((deployment: any, index: number) => (
69+
{
70+
configMapData?.map((deployment: any, index: number) => (
6971

70-
<div key={index} className="flex flex-col gap-2">
71-
<h3 className="font-bold flex-row text-l p-2">
72-
{`${index + 1}.`} <span className="text-blue-500"> {index == 0 ? findName(workLoadOne || workLoadTwo) : findName(workLoadTwo)} </span> <small className="text-sm">({index == 0 ? workLoadOne || workLoadTwo : workLoadTwo})</small>
73-
&nbsp; <small className="text-xs font-light text-green-500">{loading ? "Loading..." : ""}</small>
74-
</h3>
75-
<div className="flex flex-col gap-2">
76-
<CountTable deployments={deployment} />
77-
<ConfigMapDeployments deployments={deployment} updateDataWithIndex={updateDataWithIndex} title="Services" />
72+
<div key={index} className="flex flex-col gap-2">
73+
<h3 className="font-bold flex-row text-l p-2">
74+
{`${index + 1}.`} <span className="text-blue-500">
75+
{index == 0 ? findName(workLoadOne || workLoadTwo) : findName(workLoadTwo)} </span>
76+
<small className="text-sm">({index == 0 ? workLoadOne || workLoadTwo : workLoadTwo})</small>
77+
&nbsp; <small className="text-xs font-light text-green-500">{loading ? "Loading..." : ""}</small>
78+
</h3>
79+
<div className="flex flex-col gap-2">
80+
<CountTable deployments={deployment} />
81+
<ConfigMapDeployments deployments={deployment} updateDataWithIndex={updateDataWithIndex} title="Services" />
82+
</div>
7883
</div>
79-
</div>
80-
))
81-
}
84+
))
85+
}
86+
</div>
8287
</div>
83-
</div>
84-
88+
8589
);
8690
};
8791

src/components/configmap/tables/countInfo.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import { deploymentHavingIssue, filterDeployments } from '@/functions';
22
import React from 'react';
33

44
const CountTable = (props: any) => {
5-
const allServices = filterDeployments(props.deployments);
6-
const deploymentHavingIssues = deploymentHavingIssue(allServices);
5+
const allServices = props.deployments? filterDeployments(props.deployments) : [];
6+
const deploymentHavingIssues = allServices.length ? deploymentHavingIssue(allServices): []
77

88
return (
99
<div className="overflow-x-auto">

src/components/configmap/tables/deploymentItem.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const ConfigMapDeploymentList = ({ deployment, index, updateDataWithIndex }: { d
1010
<td className="border border-gray-300 px-4 py-2">{deployment.name}</td>
1111
<td className="border border-gray-300 px-4 py-2 block-inline cursor-pointer"> <p title='Replicas'>{deployment.replicas}</p></td>
1212
<td className="border border-gray-300 px-4 py-2 block-inline cursor-pointer"> <p title='Available'>{deployment.available}</p></td>
13-
<td className="border border-gray-300 px-4 py-2 block-inline"> <a href="javascript:;" onClick={() => updateDataWithIndex(index, deployment.isConfigMapOpen ? false : true)} className="text-blue-500"> {deployment.isConfigMapOpen ? "close" : "open"}</a></td>
13+
<td className="border border-gray-300 px-4 py-2 block-inline "> <a onClick={() => updateDataWithIndex(index, deployment.isConfigMapOpen ? false : true)} className="text-blue-500 cursor-pointer"> {deployment.isConfigMapOpen ? "close" : "open"}</a></td>
1414
</tr>
1515
<tr className={deployment.isConfigMapOpen ? "" : "hidden"}>
1616
<td className={`border border-gray-300 px-4 py-2 text-sm gap-2 ${deployment.setCurrentView ? "bg-green-100" : ""} `} colSpan={5}>
@@ -19,15 +19,15 @@ const ConfigMapDeploymentList = ({ deployment, index, updateDataWithIndex }: { d
1919
<tbody>
2020
{
2121
deployment && configMapArray.map((item: any, index: number) => {
22-
return<tr className="border-b-gray-50"> <td>{index+1}</td> <td> {item[0]} </td><td> {item[1]} </td></tr>
22+
return<tr className="border-b-gray-50"><td>{index+1}</td> <td>{item[0]} </td><td>{item[1]}</td></tr>
2323
})
2424
}
2525
</tbody>
2626
</table>
2727
</div>
2828
<div className="gap-3">
2929
<hr className=" border-gray-300 mt-3 mb-3"></hr>
30-
<a className="text-blue-500" href="javascript:;" onClick={() => updateDataWithIndex(index, deployment.setCurrentView ? false : true, false)} > {deployment.setCurrentView ? "unset" : "set"} current view</a>
30+
<a className="text-blue-500 cursor-pointer" onClick={() => updateDataWithIndex(index, deployment.setCurrentView ? false : true, false)} > {deployment.setCurrentView ? "unset" : "set"} current view</a>
3131
</div>
3232

3333
</td>

src/components/keyvault/index.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,10 @@ const KeyVaultTab = (props: any) => {
2020
].filter(Boolean).join('&');
2121
try {
2222
const response = await httpRequest.get(`/api/keyvault?${queryString}`);
23-
setData(response.data);
24-
saveKvData(response.data);
23+
if (response?.data?.length) {
24+
setData(response.data);
25+
saveKvData(response.data);
26+
}
2527
} catch (error: any) {
2628
setError(error.message);
2729
props.closeLoading(false);
@@ -34,7 +36,7 @@ const KeyVaultTab = (props: any) => {
3436
}
3537
const getFromLc = () => {
3638
const kvData = getKvData();
37-
const getKeys = kvData[0];
39+
const getKeys = kvData && kvData.length ? kvData[0] : "";
3840
setKvKeys(Object.keys(getKeys).map((item) => item));
3941
setData(kvData);
4042
}

src/functions/localstorage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ export const getDeploymentsData = () => {
1010
}
1111

1212
export const saveConfigData = (deployments: Deployment[]) => {
13-
localStorage.setItem('configMap', JSON.stringify(deployments));
13+
localStorage.setItem('configMap', btoa(JSON.stringify(deployments)));
1414
}
1515

1616
export const getConfigData = () => {
1717
const deployments = localStorage.getItem('configMap');
18-
return deployments ? JSON.parse(deployments) : [];
18+
return deployments ? JSON.parse(atob(deployments)) : [];
1919
}
2020

2121
export const saveKvData = (kv: any) => {

src/setting.ts

Lines changed: 27 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,38 @@
1-
21
export const workLoads = [
32
{
4-
name: "dev2", // set env name
5-
value: "aks-workload-name", // set env workload name as value
3+
name: "dev2",
4+
value: "aks-dev2-non-pci-eastus",
5+
}, {
6+
name: "dev3",
7+
value: "aks-dev3-non-pci-eastus",
8+
},
9+
{
10+
name: "uat2",
11+
value: "aks-uat2-non-pci-eastus",
12+
},
13+
{
14+
name: "prod",
15+
value: "aks-prod-non-pci-eastus",
616
}
717
];
818

919
export const keyVaults = [
1020
{
11-
name: "aks-workload-name", // your aks workload name
12-
value: "key-vault-name", // your key vault name
21+
name: "aks-dev2-non-pci-eastus",
22+
value: "kvDev2NonPCI-US-E",
23+
}, {
24+
name: "kv-dev3-non-pci-us-e",
25+
value: "aks-dev3-non-pci-eastus",
26+
},
27+
{
28+
name: "kv-uat2-non-pci-us-e",
29+
value: "aks-uat2-non-pci-eastus",
30+
},
31+
{
32+
name: "kv-prod-non-pci-us-e",
33+
value: "aks-prod-non-pci-eastus",
1334
}
1435
]
1536

1637
export const DEFAULT_NAMESPACE = "default";
17-
export const DEFAULT_IGNORED_NAME = "redis";
38+
export const DEFAULT_IGNORED_NAME = "zipkin";

0 commit comments

Comments
 (0)