Fix issue with user authentication and VACUUM

utelle · utelle · commit 0d627f7e3fb2 · 2021-04-26T10:34:45.000+02:00
The original user authentication extension checks the wrong database on attaching a database. This results in errors if the attached database is not under user authentication control (like on executing a VACUUM command).
diff --git a/src/userauth.c b/src/userauth.c
@@ -90,7 +90,7 @@ static int userAuthCheckLogin(
   int rc;
 
   *peAuth = UAUTH_Unknown;
-  if( !userTableExists(db, "main") ){
+  if( !userTableExists(db, zDb) ){
     *peAuth = UAUTH_Admin;  /* No sqlite_user table.  Everybody is admin. */
     return SQLITE_OK;
   }

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ static int userAuthCheckLogin(`
`90`	`90`	`int rc;`
`91`	`91`
`92`	`92`	`*peAuth = UAUTH_Unknown;`
`93`		`- if( !userTableExists(db, "main") ){`
	`93`	`+ if( !userTableExists(db, zDb) ){`
`94`	`94`	`peAuth = UAUTH_Admin; / No sqlite_user table. Everybody is admin. */`
`95`	`95`	`return SQLITE_OK;`
`96`	`96`	`}`