Fix a bug in shutdown code

utelle · utelle · commit a5ac5eb26412 · 2022-09-08T09:27:41.000+02:00
Cleaning up memory in internal function `sqlite3mcTermCipherTables` leads to a crash due to a bug. The bug went undetected during testing, because the SQLite shell doesn't call `sqlite3_shutdown`.
diff --git a/src/sqlite3mc.c b/src/sqlite3mc.c
@@ -587,9 +587,9 @@ sqlite3mcTermCipherTables()
     {
       int k;
       CipherParams* params = globalCodecParameterTable[n].m_params;
-      for (k = 0; params->m_name[0] != 0; ++k)
+      for (k = 0; params[k].m_name[0] != 0; ++k)
       {
-        sqlite3_free(params->m_name);
+        sqlite3_free(params[k].m_name);
       }
       sqlite3_free(globalCodecParameterTable[n].m_params);
     }

Original file line number	Diff line number	Diff line change
`@@ -587,9 +587,9 @@ sqlite3mcTermCipherTables()`
`587`	`587`	`{`
`588`	`588`	`int k;`
`589`	`589`	`CipherParams* params = globalCodecParameterTable[n].m_params;`
`590`		`- for (k = 0; params->m_name[0] != 0; ++k)`
	`590`	`+ for (k = 0; params[k].m_name[0] != 0; ++k)`
`591`	`591`	`{`
`592`		`- sqlite3_free(params->m_name);`
	`592`	`+ sqlite3_free(params[k].m_name);`
`593`	`593`	`}`
`594`	`594`	`sqlite3_free(globalCodecParameterTable[n].m_params);`
`595`	`595`	`}`