Release v0.12.2

[jamesbrink]

Summary

Upgrade ComfyUI to v0.12.2 with numerous fixes and improvements across the flake.

ComfyUI Core

• Upgrade to ComfyUI v0.12.2 (tracking Comfy-Org/ComfyUI)
• Vendor new upstream deps: comfy-kitchen, comfy-aimdo
• Add gradio (vendored wheel) for custom nodes that import it (e.g. ComfyUI-LLaMA-Mesh)
• Add sageattention + runtime triton for SageAttention support
• Include google-generativeai, ollama, pytorch-lightning, google-genai in runtime

Custom Nodes

• Bump KJNodes, GGUF, LTXVideo, Florence2, MMAudio, WanVideoWrapper to HEAD
• Restore LTXVideo compatibility (precompute_freqs_cis)
• Refresh workflow template input files

Model Downloader

• Add HF auth header support for gated models
• Cover *.hf.co subdomains (e.g. cdn-lfs.hf.co) in auth checks
• Parse stored_tokens as JSON for correct HF token extraction
• Only send Authorization headers over HTTPS (prevent token leakage)
• Improve progress button contrast on PrimeVue themes
• Unify disabled-button style constants across all code paths

Fixes

• Manager venv no longer overrides Nix-pinned core packages (prevents torch/numpy ABI conflicts)
• Include missing X11/XCB libs in runtime closure (fixes libxcb.so.1 errors)
• Patch mergekit at launcher-time to avoid pydantic v2 torch.Tensor schema crash
• Patch comfyui-custom-scripts to avoid writes into read-only Nix store

Documentation

• Consolidate AGENTS.md and .github/copilot-instructions.md as symlinks to CLAUDE.md
• Sync README data structure (.pip-packages → .venv, add fonts/, .cache/)
• Update CHANGELOG with all changes

Test plan

• nix flake check passes all 5 checks (ruff, pyright, nixfmt, shellcheck, package build)
• nix run launches ComfyUI successfully on macOS
• Model downloads from HuggingFace (including gated models) work with auth
• ComfyUI Manager installs packages into .venv/ correctly
• Docker image builds via nix run .#buildDocker

[greptile-apps]

Greptile Overview

Greptile Summary

This PR updates the flake to track ComfyUI v0.12.2 (moving upstream to Comfy-Org/ComfyUI), refreshes version pins for vendored wheels and bundled custom nodes, and expands the runtime environment to include new upstream deps (e.g., comfy-kitchen/comfy-aimdo, gradio, sageattention) plus additional common custom-node dependencies. It also adjusts the launcher/runtime behavior (venv precedence control, patching certain third-party nodes at startup) and improves the model_downloader UI/patch to better handle HuggingFace gated downloads and disabled-button contrast.

The changes largely fit existing repo patterns: version pin updates in nix/versions.nix, wheel vendoring in nix/vendored-packages.nix, and runtime/launcher behavior in nix/packages.nix, with the model downloader custom node updated in both Python and JS.

Confidence Score: 3/5

• This PR is close to mergeable but has a couple of concrete runtime breakages to address.
• Most changes are version pin/docs updates and straightforward dependency additions. However, there is at least one definite runtime error introduced in the model_downloader patch (missing import for json in the new token parsing helper), and the launcher-time patch for comfyui-custom-scripts can introduce an os reference without ensuring import os exists, which can crash on import for affected users. Fixing those should materially reduce merge risk.
• src/custom_nodes/model_downloader/model_downloader_patch.py and nix/packages.nix (launcher patching block)

Important Files Changed

Filename	Overview
.github/copilot-instructions.md	Adds a symlink to CLAUDE.md for Copilot instructions; no functional code changes.
AGENTS.md	Replaces AGENTS.md content with a symlink to CLAUDE.md; documentation-only change.
CHANGELOG.md	Updates changelog with Unreleased notes reflecting the v0.12.2 upgrade and related fixes.
CLAUDE.md	Expands repository guidance for commands, architecture, and new v0.12.2 behaviors; no runtime code.
README.md	Docs update to reflect venv-based runtime installs, directory structure changes, and updated upstream ComfyUI org link.
flake.nix	Updates flake description to mention ComfyUI v0.12.2; no logic changes.
nix/apps.nix	Points update-checker to Comfy-Org/ComfyUI releases endpoint; minor change.
nix/packages.nix	Switches ComfyUI upstream org, updates patches and adds new runtime deps; introduces launcher-time patching and venv precedence logic that needs careful review.
nix/patches/comfyui-ltxvideo-compat.patch	Adds a compatibility shim for precompute_freqs_cis to support ComfyUI-LTXVideo against newer ComfyUI.
nix/python-overrides.nix	Adds torchmetrics build input overrides (setuptools/wheel) to fix PEP517 build failures.
nix/template-inputs.nix	Regenerates template input URLs/hashes and improves quoting of generated symlink names in runCommand.
nix/vendored-packages.nix	Adds new vendored wheels (comfy-kitchen, comfy-aimdo, gradio(+client), sageattention) and switches to rec to allow self-references.
nix/versions.nix	Bumps ComfyUI and vendored/custom node pins to v0.12.2-era revisions and adds version pins for new vendored wheels.
scripts/update-template-inputs.sh	Adds URL basename percent-encoding and safe store names for nix-prefetch-url; adds python3 as a dependency.
src/custom_nodes/model_downloader/js/model_downloader_core.js	Unifies disabled-button styling constants and improves contrast via inline styles and injected CSS for PrimeVue themes.
src/custom_nodes/model_downloader/model_downloader_patch.py	Adds HuggingFace token discovery and conditional Authorization headers on requests; introduces a new dependency on urlparse/Path and uses json but needs to ensure imports and error paths are correct.

Sequence Diagram

sequenceDiagram
  participant UI
  participant MDJS
  participant API
  participant HF
  participant FS

  UI->>MDJS: Click Download
  MDJS->>API: POST /api/download_model
  API->>API: Determine auth headers
  API->>HF: HEAD url
  HF-->>API: content-length
  API->>HF: GET url
  HF-->>API: bytes
  API->>FS: write + progress
  API-->>MDJS: progress updates
  MDJS-->>UI: update button
  API-->>MDJS: done/error
  MDJS-->>UI: final state

Loading

[greptile-apps]

_{16 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}