Skip to content

Commit 135dee2

Browse files
committed
small cleanup to pin code
1 parent f69e4e5 commit 135dee2

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

llama-cpp-2/src/model/params.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ impl LlamaModelParams {
5959
/// # use llama_cpp_2::model::params::kv_overrides::ParamOverrideValue;
6060
/// let mut params = pin!(LlamaModelParams::default());
6161
/// let key = CString::new("key").expect("CString::new failed");
62-
/// params.append_kv_override(&key, ParamOverrideValue::Int(50));
62+
/// params.as_mut().append_kv_override(&key, ParamOverrideValue::Int(50));
6363
///
6464
/// let kv_overrides = params.kv_overrides().into_iter().collect::<Vec<_>>();
6565
/// assert_eq!(kv_overrides.len(), 1);
@@ -71,7 +71,7 @@ impl LlamaModelParams {
7171
/// ```
7272
#[allow(clippy::missing_panics_doc)] // panics are just to enforce internal invariants, not user errors
7373
pub fn append_kv_override(
74-
self: &mut Pin<&mut Self>,
74+
mut self: Pin<&mut Self>,
7575
key: &CStr,
7676
value: kv_overrides::ParamOverrideValue,
7777
) {

simple/src/main.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
clippy::cast_sign_loss
77
)]
88

9-
use std::collections::BTreeMap;
10-
use std::ffi::{CStr, CString};
9+
use std::ffi::CString;
1110
use anyhow::{anyhow, bail, Context, Result};
1211
use clap::Parser;
1312
use hf_hub::api::sync::ApiBuilder;
@@ -125,7 +124,7 @@ fn main() -> Result<()> {
125124

126125
for (k, v) in key_value_overrides.iter() {
127126
let k = CString::new(k.as_bytes()).with_context(|| format!("invalid key: {}", k))?;
128-
model_params.append_kv_override(k.as_c_str(), *v);
127+
model_params.as_mut().append_kv_override(k.as_c_str(), *v);
129128
}
130129

131130
let model_path = model

0 commit comments

Comments
 (0)