nats-streaming is always creating a group

[slawo]

go-pubsub/natss/source.go

Line 179 in 34bed0f

subscription, err := conn.QueueSubscribe(mq.topic, mq.consumerID, f, opts...)

subscription, err := conn.QueueSubscribe(mq.topic, mq.consumerID, f, opts...) creates a group.

go-pubsub/natss/source.go

Line 170 in 34bed0f

opts = append(opts, stan.DurableName(mq.consumerID))

By default the library creates a durable connection

go-pubsub/natss/source.go

Line 99 in 34bed0f

conn, err := stan.Connect(mq.clusterID, mq.consumerID+generateID(), stan.NatsURL(mq.natsURL), stan.SetConnectionLostHandler(func(_ stan.Conn, e error) {

adding to this mq.consumerID+generateID() creates a new client id on each reconnect which creates a major issue in case of staled connections as even with 1 inflight a message can be waiting to timeout wile a consumer reconnects to the same group with a new client id and gets next events... when the stalled connection dies or the message timeout on nats server the message is released and re-delivered out of order.

[slawo]

Most of our projectors don't require a group, nor do they require a new client id per connection, this should be fixed to avoid those issues.