Prevent stack overflow with exported testing (:

Author: rentziass

main.go

@@ -1,7 +1,8 @@
 package main
 
 import (
-	"log"
+	"flag"
+	"fmt"
 	"os"
 
 	"github.com/utilitywarehouse/patrol/patrol"
@@ -13,14 +14,38 @@ type Repo struct {
 }
 
 func main() {
-	if len(os.Args) < 2 {
-		log.Fatal("please provide the path to the repository")
+	revision := flag.String("from", "", "revision that should be used to detected "+
+		"changes in HEAD.\nE.g.: -from=a0e002f951f56d53d552f9427b3331b11ea66e92")
+
+	flag.Parse()
+
+	args := flag.Args()
+
+	if len(args) < 1 {
+		fmt.Fprintf(os.Stderr, "please provide the path to the repository\n")
+		os.Exit(1)
+	}
+
+	if *revision == "" {
+		fmt.Fprintf(os.Stderr, "please set `from` flag:\n\tpatrol -from=a0e002f951f56d53d552f9427b3331b11ea66e92 .\n")
+		os.Exit(1)
 	}
 
-	repoPath := os.Args[1]
+	repoPath := args[0]
 
-	_, err := patrol.NewRepo(repoPath)
+	repo, err := patrol.NewRepo(repoPath)
 	if err != nil {
-		panic(err)
+		fmt.Fprintf(os.Stderr, "error: %s\n", err.Error())
+		os.Exit(1)
+	}
+
+	changes, err := repo.ChangesFrom(*revision)
+	if err != nil {
+		fmt.Fprintf(os.Stderr, "error: %s\n", err.Error())
+		os.Exit(1)
+	}
+
+	for _, c := range changes {
+		fmt.Println(c)
 	}
 }

patrol/repo.go

@@ -55,8 +55,10 @@ func NewRepo(path string) (*Repo, error) {
 
 				var imports []string
 				for _, file := range pkg.Files {
-					for _, imp := range file.Imports {
-						imports = append(imports, strings.ReplaceAll(imp.Path.Value, `"`, ""))
+					if !strings.HasSuffix(file.Name.Name, "_test") {
+						for _, imp := range file.Imports {
+							imports = append(imports, strings.ReplaceAll(imp.Path.Value, `"`, ""))
+						}
 					}
 				}
 				repo.AddPackage(strings.TrimPrefix(p, path+"/"), imports)

patrol/repo_test.go

@@ -9,7 +9,6 @@ func TestRepo(t *testing.T) {
 			Name:           "change within module",
 			Description: "A change to a package within the same module\n" +
 				"should flag depending packages as changed",
-			TestAgainstRevision: "HEAD~1",
 			ExpectedChangedPackages: []string{
 				"github.com/utilitywarehouse/internalchange/internal/bar",
 				"github.com/utilitywarehouse/internalchange/pkg/foo",
@@ -21,7 +20,6 @@ func TestRepo(t *testing.T) {
 			Name:           "change in go modules dependency",
 			Description: "A change to a go modules dependency\n" +
 				"should flag depending packages as changed",
-			TestAgainstRevision: "HEAD~1",
 			ExpectedChangedPackages: []string{
 				"github.com/utilitywarehouse/modules",
 			},
@@ -31,11 +29,19 @@ func TestRepo(t *testing.T) {
 			Name:           "change in vendored dependencies",
 			Description: "A change to a vendored dependency\n" +
 				"should flag depending packages as changed",
-			TestAgainstRevision: "HEAD~1",
 			ExpectedChangedPackages: []string{
 				"github.com/utilitywarehouse/vendoring",
 			},
 		},
+		RepoTest{
+			TestdataFolder: "exportedtesting",
+			Name:           "change in a package with packagename_test test package",
+			Description: "A change to package x that is being tested " +
+				"using x_test package should not result in a stack overflow :D",
+			ExpectedChangedPackages: []string{
+				"github.com/utilitywarehouse/exportedtesting/foo",
+			},
+		},
 	}
 
 	tests.Run(t)

patrol/testdata/exportedtesting/commits/1/foo/foo.go

@@ -0,0 +1,3 @@
+package foo
+
+type A struct{}

patrol/testdata/exportedtesting/commits/1/foo/foo_test.go

@@ -0,0 +1,12 @@
+package foo_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/utilitywarehouse/exportedtesting/foo"
+)
+
+func TestFoo(t *testing.T) {
+	fmt.Println(&foo.A{})
+}

patrol/testdata/exportedtesting/commits/1/go.mod

@@ -0,0 +1,3 @@
+module github.com/utilitywarehouse/exportedtesting
+
+go 1.17

patrol/testdata/exportedtesting/commits/2/foo/foo.go

@@ -0,0 +1,6 @@
+package foo
+
+type (
+	A struct{}
+	B struct{}
+)

patrol/testdata/exportedtesting/commits/2/foo/foo_test.go

@@ -0,0 +1,12 @@
+package foo_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/utilitywarehouse/exportedtesting/foo"
+)
+
+func TestFoo(t *testing.T) {
+	fmt.Println(&foo.A{})
+}

patrol/testdata/exportedtesting/commits/2/go.mod

@@ -0,0 +1,3 @@
+module github.com/utilitywarehouse/exportedtesting
+
+go 1.17