perf(turbopack): avoid redundant Box::pin

Author: xusd320

turbopack/crates/turbo-tasks/Cargo.toml

@@ -33,20 +33,15 @@ futures = { workspace = true }
 indexmap = { workspace = true, features = ["serde"] }
 mopa = "0.2.0"
 once_cell = { workspace = true }
-parking_lot = { workspace = true, features = ["serde"] }
+parking_lot = { workspace = true, features = ["serde"]}
 pin-project-lite = { workspace = true }
 rayon = { workspace = true }
 regex = { workspace = true }
 rustc-hash = { workspace = true }
 serde = { workspace = true, features = ["rc", "derive"] }
 serde_json = { workspace = true }
 serde_regex = "1.1.0"
-shrink-to-fit = { workspace = true, features = [
-  "indexmap",
-  "serde_json",
-  "smallvec",
-  "nightly",
-] }
+shrink-to-fit = { workspace=true,features = ["indexmap", "serde_json", "smallvec", "nightly"] }
 smallvec = { workspace = true }
 thiserror = { workspace = true }
 tokio = { workspace = true, features = ["full"] }

turbopack/crates/turbo-tasks/src/task/task_input.rs

@@ -67,7 +67,7 @@ where
     async fn resolve_input(&self) -> Result<Self> {
         let mut resolved = Vec::with_capacity(self.len());
         for value in self {
-            resolved.push(Box::pin(value.resolve_input()).await?);
+            resolved.push(value.resolve_input().await?);
         }
         Ok(resolved)
     }

turbopack/crates/turbopack-core/src/compile_time_info.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use serde::{Deserialize, Serialize};
 use turbo_rcstr::RcStr;
-use turbo_tasks::{FxIndexMap, NonLocalValue, ResolvedVc, TaskInput, Vc, trace::TraceRawVcs};
+use turbo_tasks::{FxIndexMap, NonLocalValue, ResolvedVc, Vc, trace::TraceRawVcs};
 use turbo_tasks_fs::FileSystemPath;
 
 use crate::environment::Environment;
@@ -102,7 +102,7 @@ macro_rules! free_var_references {
 // TODO: replace with just a `serde_json::Value`
 // https://linear.app/vercel/issue/WEB-1641/compiletimedefinevalue-should-just-use-serde-jsonvalue
 #[turbo_tasks::value]
-#[derive(Debug, Clone, Hash, TaskInput)]
+#[derive(Debug, Clone, Hash)]
 pub enum CompileTimeDefineValue {
     Null,
     Bool(bool),

turbopack/crates/turbopack-ecmascript/src/references/constant_value.rs

@@ -9,7 +9,7 @@ use swc_core::{
     quote,
 };
 use turbo_rcstr::RcStr;
-use turbo_tasks::{NonLocalValue, TaskInput, Vc, debug::ValueDebugFormat, trace::TraceRawVcs};
+use turbo_tasks::{NonLocalValue, Vc, debug::ValueDebugFormat, trace::TraceRawVcs};
 use turbopack_core::{chunk::ChunkingContext, compile_time_info::CompileTimeDefineValue};
 
 use super::AstPath;
@@ -29,7 +29,6 @@ use crate::{
     TraceRawVcs,
     ValueDebugFormat,
     NonLocalValue,
-    TaskInput,
 )]
 pub struct ConstantValueCodeGen {
     value: CompileTimeDefineValue,

turbopack/crates/turbopack-nodejs/src/chunking_context.rs

@@ -321,10 +321,10 @@ impl ChunkingContext for NodeJsChunkingContext {
         extension: RcStr,
     ) -> Result<Vc<FileSystemPath>> {
         let root_path = self.chunk_root_path.clone();
-        let name = ident
-            .output_name(self.root_path.clone(), prefix, extension)
-            .owned()
-            .await?;
+        let mut name = ident
+            .output_name(self.root_path.clone(), prefix, extension.clone())
+            .await?
+            .to_string();
         if !name.ends_with(extension.as_str()) {
             name.push_str(&extension);
         }