feat(turbopack): static asset support runtime publicPath generate #64
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Turbopack's ability to handle static assets and chunks by implementing a flexible runtime public path mechanism. This allows the base URL for loading assets to be determined dynamically at runtime, typically by checking Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
umi-next 侧的 pr 我先直接合并了，等后续 bump next.js 的时候我把这些 commit 合并一下，目前主要为了记录一些更改(或许后面可能不需要调整) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a runtime function getPublicPath to handle runtime publicPath logic, similar to webpack's __webpack_public_path__. It addresses static asset and chunk runtime publicPath logic. The changes involve modifying runtime-base.ts, runtime-types.d.ts, runtime-utils.ts, runtime_functions.rs, and ecma.rs to implement this functionality. The review focuses on correctness and potential issues in the implementation.
For: utooland/utoo#2244
append pr for: #63
添加一个运行时函数叫
getPublicPath，用于处理 runtime publicPath 的逻辑，类似于 webpack 的__webpack_public_path__处理: https://webpack.js.org/guides/public-path/#on-the-fly同时处理静态资源以及 chunk 的 runtime publicPath 逻辑:
静态资源拼接:
chunk publicPath: