Skip to content

fix(turbopack): runtimePublic prefix deal #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fireairforce merged 1 commit into from
Nov 5, 2025
Merged

fix(turbopack): runtimePublic prefix deal #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion turbopack/crates/turbopack-ecmascript-runtime/js/src/browser/runtime/base/runtime-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,12 @@ function getPathFromScript(
: chunkScript.getAttribute('src')!
const src = decodeURIComponent(chunkUrl.replace(/[?#].*$/, ''))
const runtimeBasePath = getRuntimeChunkBasePath()
const path = src.startsWith(runtimeBasePath)
let path = src.startsWith(runtimeBasePath)
? src.slice(runtimeBasePath.length)
: src
if (path.startsWith('/')) {
path = path.slice(1)
}
Comment on lines +380 to +385
Copy link

@gemini-code-assist gemini-code-assist bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

这部分逻辑可以通过方法链和正则表达式来简化，使其成为一个单行表达式。这样不仅代码更简洁，而且可以使用 const 代替 let，增强代码的不可变性，这通常是推荐的最佳实践。

  const path = (src.startsWith(runtimeBasePath) ? src.slice(runtimeBasePath.length) : src).replace(/^\//, '');

return path as ChunkPath | ChunkListPath
}

Expand Down
Loading