Skip to content

feat(turbopack): add resolve plugin condition variant of Always and Never #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xusd320 merged 1 commit into from
Jan 9, 2026
Merged

feat(turbopack): add resolve plugin condition variant of Always and Never #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 31 additions & 49 deletions turbopack/crates/turbopack-core/src/resolve/plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,48 +11,42 @@ use crate::{

/// A condition which determines if the hooks of a resolve plugin gets called.
#[turbo_tasks::value]
pub struct AfterResolvePluginCondition {
root: FileSystemPath,
glob: ResolvedVc<Glob>,
pub enum AfterResolvePluginCondition {
Glob {
root: FileSystemPath,
glob: ResolvedVc<Glob>,
},
Always,
Never,
}

#[turbo_tasks::value_impl]
impl AfterResolvePluginCondition {
#[turbo_tasks::function]
pub fn new(root: FileSystemPath, glob: ResolvedVc<Glob>) -> Vc<Self> {
AfterResolvePluginCondition { root, glob }.cell()
}

#[turbo_tasks::function]
pub async fn matches(&self, fs_path: FileSystemPath) -> Result<Vc<bool>> {
let root = self.root.clone();
let glob = self.glob.await?;

let path = fs_path;

if let Some(path) = root.get_path_to(&path)
&& glob.matches(path)
{
return Ok(Vc::cell(true));
}

Ok(Vc::cell(false))
pub fn new_with_glob(root: FileSystemPath, glob: ResolvedVc<Glob>) -> Vc<Self> {
AfterResolvePluginCondition::Glob { root, glob }.cell()
}
}

#[turbo_tasks::value(transparent)]
pub struct OptionAfterResolvePluginCondition(Option<ResolvedVc<AfterResolvePluginCondition>>);

#[turbo_tasks::value_impl]
impl OptionAfterResolvePluginCondition {
impl AfterResolvePluginCondition {
#[turbo_tasks::function]
pub fn none() -> Vc<Self> {
Vc::cell(None)
}
pub async fn matches(&self, fs_path: FileSystemPath) -> Result<Vc<bool>> {
match self {
AfterResolvePluginCondition::Glob { root, glob } => {
let path = fs_path;

if let Some(path) = root.get_path_to(&path)
&& glob.await?.matches(path)
{
return Ok(Vc::cell(true));
}

#[turbo_tasks::function]
pub fn some(condition: ResolvedVc<AfterResolvePluginCondition>) -> Vc<Self> {
Vc::cell(Some(condition))
Ok(Vc::cell(false))
}
AfterResolvePluginCondition::Always => Ok(Vc::cell(true)),
AfterResolvePluginCondition::Never => Ok(Vc::cell(false)),
}
}
}

Expand All @@ -61,6 +55,8 @@ impl OptionAfterResolvePluginCondition {
pub enum BeforeResolvePluginCondition {
Request(ResolvedVc<Glob>),
Modules(FxHashSet<RcStr>),
Always,
Never,
}

#[turbo_tasks::value_impl]
Expand Down Expand Up @@ -92,30 +88,16 @@ impl BeforeResolvePluginCondition {
false
}
}
BeforeResolvePluginCondition::Always => true,
BeforeResolvePluginCondition::Never => false,
}))
}
}

#[turbo_tasks::value(transparent)]
pub struct OptionBeforeResolvePluginCondition(Option<ResolvedVc<BeforeResolvePluginCondition>>);

#[turbo_tasks::value_impl]
impl OptionBeforeResolvePluginCondition {
#[turbo_tasks::function]
pub fn none() -> Vc<Self> {
Vc::cell(None)
}

#[turbo_tasks::function]
pub fn some(condition: ResolvedVc<BeforeResolvePluginCondition>) -> Vc<Self> {
Vc::cell(Some(condition))
}
}

#[turbo_tasks::value_trait]
pub trait BeforeResolvePlugin {
#[turbo_tasks::function]
fn before_resolve_condition(self: Vc<Self>) -> Vc<OptionBeforeResolvePluginCondition>;
fn before_resolve_condition(self: Vc<Self>) -> Vc<BeforeResolvePluginCondition>;

#[turbo_tasks::function]
fn before_resolve(
Expand All @@ -130,7 +112,7 @@ pub trait BeforeResolvePlugin {
pub trait AfterResolvePlugin {
/// A condition which determines if the hooks gets called.
#[turbo_tasks::function]
fn after_resolve_condition(self: Vc<Self>) -> Vc<OptionAfterResolvePluginCondition>;
fn after_resolve_condition(self: Vc<Self>) -> Vc<AfterResolvePluginCondition>;

/// This hook gets called when a full filepath has been resolved and the
/// condition matches. If a value is returned it replaces the resolve
Expand Down
Loading