Skip to content

feat(pack): publicPath support runtime #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fireairforce merged 2 commits into from
Oct 14, 2025
Merged

feat(pack): publicPath support runtime #2245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e77e5a
feat(pack): support output.publicPath: runtime
fireairforce Oct 13, 2025
696b67d
feat(pack): support output.publicPath: runtime
fireairforce Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions crates/pack-core/js/src/umd/runtime-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,6 @@ declare var TURBOPACK_NEXT_CHUNK_URLS: ChunkUrl[] | undefined;
declare var CHUNK_BASE_PATH: string;
declare var CHUNK_SUFFIX_PATH: string;

function normalizeChunkPath(path: string) {
if (path.startsWith("/")) {
path = path.substring(1);
} else if (path.startsWith("./")) {
path = path.substring(2);
}

if (!path.endsWith("/")) {
path += "/";
}

return path;
}

const NORMALIZED_CHUNK_BASE_PATH = normalizeChunkPath(CHUNK_BASE_PATH);

interface TurbopackBrowserBaseContext<M> extends TurbopackBaseContext<M> {
R: ResolvePathFromModule;
}
Expand Down Expand Up @@ -242,7 +226,7 @@ function instantiateRuntimeModule(
* Returns the URL relative to the origin where a chunk can be fetched from.
*/
function getChunkRelativeUrl(chunkPath: ChunkPath | ChunkListPath): ChunkUrl {
return `${NORMALIZED_CHUNK_BASE_PATH}${chunkPath
return `${CHUNK_BASE_PATH}${chunkPath
.split("/")
.map((p) => encodeURIComponent(p))
.join("/")}${CHUNK_SUFFIX_PATH}` as ChunkUrl;
Expand Down
6 changes: 6 additions & 0 deletions crates/pack-core/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,6 +1426,12 @@ impl Config {
.and_then(|o| o.public_path.clone())
.unwrap_or("".into());

// Special handling for "runtime" value - return a marker that will be
// replaced at runtime with window.publicPath
if public_path.as_str() == "runtime" {
return Ok(Vc::cell("__RUNTIME_PUBLIC_PATH__".into()));
}

Ok(Vc::cell(
format!("{}/", public_path.trim_end_matches("/")).into(),
))
Expand Down
0 ...ts/snapshot/basic/public_path/config.json → ...ts/snapshot/public_path/basic/config.json
View file
Open in desktop
File renamed without changes.
0 ...napshot/basic/public_path/input/asset.jpg → ...napshot/public_path/basic/input/asset.jpg
View file
Open in desktop
File renamed without changes
0 ...snapshot/basic/public_path/input/index.js → ...snapshot/public_path/basic/input/index.js
View file
Open in desktop
File renamed without changes.
0 .../snapshot/basic/public_path/input/lazy.js → .../snapshot/public_path/basic/input/lazy.js
View file
Open in desktop
File renamed without changes.
0 ...sic/public_path/output/asset.c77b3abb.jpg → ...blic_path/basic/output/asset.c77b3abb.jpg
View file
Open in desktop
File renamed without changes
16 changes: 8 additions & 8 deletions ...pshot_basic_public_path_input_4bf7ccdf.js → ...pshot_public_path_basic_input_4bf91212.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...t_basic_public_path_input_4bf7ccdf.js.map → ...t_public_path_basic_input_4bf91212.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 22 additions & 3 deletions ...snapshot/basic/public_path/output/main.js → ...snapshot/public_path/basic/output/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...shot/basic/public_path/output/main.js.map → ...shot/public_path/basic/output/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions crates/pack-tests/tests/snapshot/public_path/runtime/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"config": {
"entry": [
{
"import": "input/index.js",
"name": "main"
}
],
"output": {
"path": "output",
"publicPath": "runtime"
},
"optimization": {
"minify": false
}
},
"runtimeType": "Production"
}


Empty file added crates/pack-tests/tests/snapshot/public_path/runtime/input/asset.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions crates/pack-tests/tests/snapshot/public_path/runtime/input/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import asset from "./asset.jpg";

export function getImageUrl() {
return asset;
}
Empty file added crates/pack-tests/tests/snapshot/public_path/runtime/output/asset.c77b3abb.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 20 additions & 0 deletions ...ath/runtime/output/crates_pack-tests_tests_snapshot_public_path_runtime_input_1245d45e.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions ...runtime/output/crates_pack-tests_tests_snapshot_public_path_runtime_input_1245d45e.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading