Merge pull request #19 from OmSaran/pass

Changes to pass all posix PJD tests

Author: vijay03

README.md

@@ -101,14 +101,7 @@ SplitFS is under active development.
 2. The current implementation of SplitFS works correctly for the following applictions: `LevelDB running YCSB, SQLite running TPCC, tar, git, rsync`. This limitation is purely due to the state of the implementation, and we aim to increase the coverage of applications by supporting more system calls in the future.
 
 ## Testing
-[PJD POSIX Test Suite](https://www.tuxera.com/community/posix-test-suite/) that tests primarily the metadata operations was run on SplitFS and yielded the following result.  
-Tests Passed: 1944 out of a total of 1957.  
-Tests that failed include: 
-1. Tests on `link` (tests 56-58, 63-65 in links/00.t)
-2. Tests on `rename` (tests 49, 53, 57, 61 in rename/00.t)
-3. Tests on `unlink` (tests 17, 22, 53 in in unlink/00.t)  
-
-We aim to to improve this to a 100% pass rate soon.
+[PJD POSIX Test Suite](https://www.tuxera.com/community/posix-test-suite/) that tests primarily the metadata operations was run on SplitFS successfully.  
 
 **Running the Test Suite**  
 Before running the tests, make sure you have [set-up ext4-DAX](#set-up-ext4-DAX)  
@@ -125,6 +118,13 @@ where `<mode>` is one of `posix`, `sync` or `strict`.  Example: `make -C tests p
 
 Tip: Redirect stderr for less verbose output: e.g `make test 2>/dev/null`
 
+## Implementation Notes
+1. Only regular files, block special files and directories (only for consistency guarantees) are handled by SplitFS, the other file types are delegated to POSIX.  
+2. Only files in the persistent memory mount are handled by SplitFS, rest are delegated to POSIX.  
+Currently this is only done by examination of absolute paths specified, we aim to have this check for relative paths too, soon.
+3. Currently, the persistent memory mount is assumed to be at `/mnt/pmem_emul/`.  
+We aim to have this controlled via a runtime environment variable soon.
+
 ## License
 
 Copyright for SplitFS is held by the University of Texas at Austin. Please contact us if you would like to obtain a license to use SplitFS in your commercial product.

splitfs/fileops_hub.c

@@ -639,13 +639,22 @@ RETT_OPEN _hub_OPEN(INTF_OPEN)
 
 #endif
 
-#if WORKLOAD_TAR | WORKLOAD_GIT | WORKLOAD_RSYNC
-
-	if(path[0] == '/' && path[1] == 'v' && path[2] == 'a' && path[3] == 'r') {
-		op_to_use = _hub_fileops;
-		goto opening;
+		/* In case of absoulate path specified, check if it belongs to the persistent memory 
+	 	* mount and only then use SplitFS, else redirect to POSIX
+		*/
+	if(path[0] == '/') {
+		int len = strlen(NVMM_PATH);
+		char dest[len + 1];
+		dest[len] = '\0';
+		strncpy(dest, path, len);
+
+		if(strcmp(dest, NVMM_PATH) != 0) {
+			op_to_use = _hub_fileops;
+			goto opening;
+		}
 	}
 
+
 	/*
         if (!strcmp(path, "/dev/shm/exec-ledger") || !strcmp(path, "/dev/shm/exec-hub")) {
 		op_to_use = _hub_fileops;
@@ -692,7 +701,6 @@ RETT_OPEN _hub_OPEN(INTF_OPEN)
 
 	}
 
-#endif // WORKLOAD_TAR
 
 	// op_to_use = _hub_managed_fileops;	
 	assert(op_to_use != NULL);