fix(linux/rm): correct prompting logic for write-protected files in Interactive::Always mode

Refactor the prompt_file_with_stat function in src/uu/rm/src/platform/linux.rs to fix inconsistent prompting for Interactive::Always. Previously, it always used non-protected wording regardless of file writability. Now, it checks if the file is writable and uses appropriate messaging (simple for writable, protected for non-writable). The match logic for Interactive::Once and PromptProtected is also simplified using a triple condition for better readability and to ensure empty vs non-empty protected files are distinguished correctly, matching expected rm behavior.

Author: mattsu2020

src/uu/rm/src/platform/linux.rs

@@ -48,28 +48,27 @@ fn prompt_file_with_stat(path: &Path, stat: &libc::stat, options: &Options) -> b
     let stdin_ok = options.__presume_input_tty.unwrap_or(false) || stdin().is_terminal();
 
     // Match original behaviour:
-    // - Interactive::Always: always prompt (with symlink/file specific message)
-    // - Otherwise: prompt only when write-protected
+    // - Interactive::Always: always prompt; use non-protected wording when writable,
+    //   otherwise fall through to protected wording.
     if options.interactive == InteractiveMode::Always {
         if is_symlink {
             return prompt_yes!("remove symbolic link {}?", path.quote());
         }
-        if len == 0 {
-            return prompt_yes!("remove regular empty file {}?", path.quote());
+        if writable {
+            return if len == 0 {
+                prompt_yes!("remove regular empty file {}?", path.quote())
+            } else {
+                prompt_yes!("remove file {}?", path.quote())
+            };
         }
-        return prompt_yes!("remove file {}?", path.quote());
+        // Not writable: use protected wording below
     }
 
-    // Interactive::Once or ::PromptProtected paths
-    match (stdin_ok, writable) {
-        (false, _) if options.interactive == InteractiveMode::PromptProtected => true,
-        (_, true) => true,
-        (_, false) if len == 0 => {
-            prompt_yes!(
-                "remove write-protected regular empty file {}?",
-                path.quote()
-            )
-        }
+    // Interactive::Once or ::PromptProtected (and non-writable Always) paths
+    match (stdin_ok, writable, len == 0) {
+        (false, _, _) if options.interactive == InteractiveMode::PromptProtected => true,
+        (_, true, _) => true,
+        (_, false, true) => prompt_yes!("remove write-protected regular empty file {}?", path.quote()),
         _ => prompt_yes!("remove write-protected regular file {}?", path.quote()),
     }
 }