fix(redox): improve error handling for unsupported safe traversal operations

Author: abendrothj

src/uucore/src/lib/features/safe_traversal.rs

@@ -120,35 +120,59 @@ pub struct DirFd {
 }
 
 impl DirFd {
-        #[cfg(target_os = "redox")]
-        pub fn read_dir(&self) -> io::Result<Vec<OsString>> {
-            Err(io::Error::new(io::ErrorKind::Other, "safe_traversal is not supported on Redox"))
-        }
+    #[cfg(target_os = "redox")]
+    pub fn read_dir(&self) -> io::Result<Vec<OsString>> {
+        Err(io::Error::new(
+            io::ErrorKind::Other,
+            "safe_traversal is not supported on Redox",
+        ))
+    }
 
-        #[cfg(target_os = "redox")]
-        pub fn unlink_at(&self, _name: &OsStr, _is_dir: bool) -> io::Result<()> {
-            Err(io::Error::new(io::ErrorKind::Other, "safe_traversal is not supported on Redox"))
-        }
+    #[cfg(target_os = "redox")]
+    pub fn unlink_at(&self, _name: &OsStr, _is_dir: bool) -> io::Result<()> {
+        Err(io::Error::new(
+            io::ErrorKind::Other,
+            "safe_traversal is not supported on Redox",
+        ))
+    }
 
-        #[cfg(target_os = "redox")]
-        pub fn chown_at(&self, _name: &OsStr, _uid: Option<u32>, _gid: Option<u32>, _follow_symlinks: bool) -> io::Result<()> {
-            Err(io::Error::new(io::ErrorKind::Other, "safe_traversal is not supported on Redox"))
-        }
+    #[cfg(target_os = "redox")]
+    pub fn chown_at(
+        &self,
+        _name: &OsStr,
+        _uid: Option<u32>,
+        _gid: Option<u32>,
+        _follow_symlinks: bool,
+    ) -> io::Result<()> {
+        Err(io::Error::new(
+            io::ErrorKind::Other,
+            "safe_traversal is not supported on Redox",
+        ))
+    }
 
-        #[cfg(target_os = "redox")]
-        pub fn fchown(&self, _uid: Option<u32>, _gid: Option<u32>) -> io::Result<()> {
-            Err(io::Error::new(io::ErrorKind::Other, "safe_traversal is not supported on Redox"))
-        }
+    #[cfg(target_os = "redox")]
+    pub fn fchown(&self, _uid: Option<u32>, _gid: Option<u32>) -> io::Result<()> {
+        Err(io::Error::new(
+            io::ErrorKind::Other,
+            "safe_traversal is not supported on Redox",
+        ))
+    }
 
-        #[cfg(target_os = "redox")]
-        pub fn chmod_at(&self, _name: &OsStr, _mode: u32, _follow_symlinks: bool) -> io::Result<()> {
-            Err(io::Error::new(io::ErrorKind::Other, "safe_traversal is not supported on Redox"))
-        }
+    #[cfg(target_os = "redox")]
+    pub fn chmod_at(&self, _name: &OsStr, _mode: u32, _follow_symlinks: bool) -> io::Result<()> {
+        Err(io::Error::new(
+            io::ErrorKind::Other,
+            "safe_traversal is not supported on Redox",
+        ))
+    }
 
-        #[cfg(target_os = "redox")]
-        pub fn fchmod(&self, _mode: u32) -> io::Result<()> {
-            Err(io::Error::new(io::ErrorKind::Other, "safe_traversal is not supported on Redox"))
-        }
+    #[cfg(target_os = "redox")]
+    pub fn fchmod(&self, _mode: u32) -> io::Result<()> {
+        Err(io::Error::new(
+            io::ErrorKind::Other,
+            "safe_traversal is not supported on Redox",
+        ))
+    }
     /// Open a directory and return a file descriptor
     pub fn open(path: &Path) -> io::Result<Self> {
         #[cfg(not(target_os = "redox"))]
@@ -218,7 +242,10 @@ impl DirFd {
     }
     #[cfg(target_os = "redox")]
     pub fn stat_at(&self, _name: &OsStr, _follow_symlinks: bool) -> io::Result<()> {
-        Err(io::Error::new(io::ErrorKind::Other, "safe_traversal is not supported on Redox"))
+        Err(io::Error::new(
+            io::ErrorKind::Other,
+            "safe_traversal is not supported on Redox",
+        ))
     }
 
     /// Get metadata for a file relative to this directory
@@ -242,7 +269,10 @@ impl DirFd {
     }
     #[cfg(target_os = "redox")]
     pub fn fstat(&self) -> io::Result<()> {
-        Err(io::Error::new(io::ErrorKind::Other, "safe_traversal is not supported on Redox"))
+        Err(io::Error::new(
+            io::ErrorKind::Other,
+            "safe_traversal is not supported on Redox",
+        ))
     }
 
     /// Read directory entries