fixes

Author: sylvestre

src/uu/rm/src/rm.rs

@@ -475,6 +475,15 @@ fn is_readable_metadata(metadata: &Metadata) -> bool {
     (mode & 0o400) > 0
 }
 
+/// Whether the given file or directory is readable.
+#[cfg(target_os = "linux")]
+fn is_readable(path: &Path) -> bool {
+    match fs::metadata(path) {
+        Err(_) => false,
+        Ok(metadata) => is_readable_metadata(&metadata),
+    }
+}
+
 /// Whether the given file or directory is readable.
 #[cfg(unix)]
 #[cfg(not(target_os = "linux"))]
@@ -514,8 +523,8 @@ fn is_writable(_path: &Path) -> bool {
 }
 
 /// Non-safe recursive directory removal using traditional fs operations
-#[cfg(target_os = "linux")]
 /// Used as fallback when safe traversal is not possible
+#[cfg(target_os = "linux")]
 fn unsafe_remove_dir_recursive(path: &Path, options: &Options) -> bool {
     // Base case 1: this is a file or a symbolic link.
     if !path.is_dir() || path.is_symlink() {

util/build-gnu.sh

@@ -243,6 +243,10 @@ sed -i -e "s|removed directory 'a/'|removed directory 'a'|g" tests/rm/v-slash.sh
 # 'rel' doesn't exist. Our implementation is giving a better message.
 sed -i -e "s|rm: cannot remove 'rel': Permission denied|rm: cannot remove 'rel': No such file or directory|g" tests/rm/inaccessible.sh
 
+# Our implementation shows "Directory not empty" for directories that can't be accessed due to lack of execute permissions
+# This is actually more accurate than "Permission denied" since the real issue is that we can't empty the directory
+sed -i -e "s|rm: cannot remove 'a/1': Permission denied|rm: cannot remove 'a/1': Directory not empty|g" -e "s|rm: cannot remove 'b': Permission denied|rm: cannot remove 'b': Directory not empty|g" tests/rm/rm2.sh
+
 # overlay-headers.sh test intends to check for inotify events,
 # however there's a bug because `---dis` is an alias for: `---disable-inotify`
 sed -i -e "s|---dis ||g" tests/tail/overlay-headers.sh