uutests: Move command specific tests in their respective tests

Author: sylvestre

.vscode/cspell.dictionaries/workspace.wordlist.txt

@@ -324,6 +324,7 @@ libc
 libstdbuf
 musl
 tmpd
+uchild
 ucmd
 ucommand
 utmpx

tests/by-util/test_cat.rs

@@ -6,10 +6,9 @@
 
 #[cfg(any(target_os = "linux", target_os = "android"))]
 use rlimit::Resource;
-#[cfg(target_os = "linux")]
+#[cfg(unix)]
 use std::fs::File;
 use std::fs::OpenOptions;
-#[cfg(not(windows))]
 use std::process::Stdio;
 use uutests::at_and_ucmd;
 use uutests::new_ucmd;
@@ -671,3 +670,40 @@ fn test_appending_same_input_output() {
         .no_stdout()
         .stderr_contains("input file is output file");
 }
+
+#[cfg(unix)]
+#[test]
+fn test_uchild_when_no_capture_reading_from_infinite_source() {
+    use regex::Regex;
+
+    let ts = TestScenario::new("cat");
+
+    let expected_stdout = b"\0".repeat(12345);
+    let mut child = ts
+        .ucmd()
+        .set_stdin(Stdio::from(File::open("/dev/zero").unwrap()))
+        .set_stdout(Stdio::piped())
+        .run_no_wait();
+
+    child
+        .make_assertion()
+        .with_exact_output(12345, 0)
+        .stdout_only_bytes(expected_stdout);
+
+    child
+        .kill()
+        .make_assertion()
+        .with_current_output()
+        .stdout_matches(&Regex::new("[\0].*").unwrap())
+        .no_stderr();
+}
+
+#[test]
+fn test_child_when_pipe_in() {
+    let ts = TestScenario::new("cat");
+    let mut child = ts.ucmd().set_stdin(Stdio::piped()).run_no_wait();
+    child.pipe_in("content");
+    child.wait().unwrap().stdout_only("content").success();
+
+    ts.ucmd().pipe_in("content").run().stdout_is("content");
+}

tests/by-util/test_chcon.rs

@@ -10,7 +10,10 @@ use std::ffi::CString;
 use std::path::Path;
 use std::{io, iter, str};
 
-use uutests::util::*;
+use uutests::at_and_ucmd;
+use uutests::new_ucmd;
+use uutests::util::TestScenario;
+use uutests::util_name;
 
 #[test]
 fn version() {

tests/by-util/test_echo.rs

@@ -2,10 +2,11 @@
 //
 // For the full copyright and license information, please view the LICENSE
 // file that was distributed with this source code.
-// spell-checker:ignore (words) araba merci
+// spell-checker:ignore (words) araba merci mright
 
 use uutests::new_ucmd;
 use uutests::util::TestScenario;
+use uutests::util::UCommand;
 use uutests::util_name;
 
 #[test]
@@ -393,6 +394,64 @@ fn slash_eight_off_by_one() {
         .stdout_only(r"\8");
 }
 
+#[test]
+fn test_normalized_newlines_stdout_is() {
+    let res = new_ucmd!().args(&["-ne", "A\r\nB\nC"]).run();
+
+    res.normalized_newlines_stdout_is("A\r\nB\nC");
+    res.normalized_newlines_stdout_is("A\nB\nC");
+    res.normalized_newlines_stdout_is("A\nB\r\nC");
+}
+
+#[test]
+fn test_normalized_newlines_stdout_is_fail() {
+    new_ucmd!()
+        .args(&["-ne", "A\r\nB\nC"])
+        .run()
+        .stdout_is("A\r\nB\nC");
+}
+
+#[test]
+fn test_cmd_result_stdout_check_and_stdout_str_check() {
+    let result = new_ucmd!().arg("Hello world").run();
+
+    result.stdout_str_check(|stdout| stdout.ends_with("world\n"));
+    result.stdout_check(|stdout| stdout.get(0..2).unwrap().eq(b"He"));
+    result.no_stderr();
+}
+
+#[test]
+fn test_cmd_result_stderr_check_and_stderr_str_check() {
+    let ts = TestScenario::new("echo");
+
+    let result = UCommand::new()
+        .arg(format!(
+            "{} {} Hello world >&2",
+            ts.bin_path.display(),
+            ts.util_name
+        ))
+        .run();
+
+    result.stderr_str_check(|stderr| stderr.ends_with("world\n"));
+    result.stderr_check(|stdout| stdout.get(0..2).unwrap().eq(b"He"));
+    result.no_stdout();
+}
+
+#[test]
+fn test_cmd_result_stdout_str_check_when_false_then_panics() {
+    new_ucmd!()
+        .args(&["-e", "\\f"])
+        .succeeds()
+        .stdout_only("\x0C\n");
+}
+
+#[cfg(unix)]
+#[test]
+fn test_cmd_result_signal_when_normal_exit_then_no_signal() {
+    let result = TestScenario::new("echo").ucmd().run();
+    assert!(result.signal().is_none());
+}
+
 mod posixly_correct {
     use super::*;
 
@@ -444,3 +503,56 @@ mod posixly_correct {
             .stdout_only("foo");
     }
 }
+
+#[test]
+fn test_child_when_run_with_a_non_blocking_util() {
+    new_ucmd!()
+        .arg("hello world")
+        .run()
+        .success()
+        .stdout_only("hello world\n");
+}
+
+// Test basically that most of the methods of UChild are working
+#[test]
+fn test_uchild_when_run_no_wait_with_a_non_blocking_util() {
+    let mut child = new_ucmd!().arg("hello world").run_no_wait();
+
+    // check `child.is_alive()` and `child.delay()` is working
+    let mut trials = 10;
+    while child.is_alive() {
+        assert!(
+            trials > 0,
+            "Assertion failed: child process is still alive."
+        );
+
+        child.delay(500);
+        trials -= 1;
+    }
+
+    assert!(!child.is_alive());
+
+    // check `child.is_not_alive()` is working
+    assert!(child.is_not_alive());
+
+    // check the current output is correct
+    std::assert_eq!(child.stdout(), "hello world\n");
+    assert!(child.stderr().is_empty());
+
+    // check the current output of echo is empty. We already called `child.stdout()` and `echo`
+    // exited so there's no additional output after the first call of `child.stdout()`
+    assert!(child.stdout().is_empty());
+    assert!(child.stderr().is_empty());
+
+    // check that we're still able to access all output of the child process, even after exit
+    // and call to `child.stdout()`
+    std::assert_eq!(child.stdout_all(), "hello world\n");
+    assert!(child.stderr_all().is_empty());
+
+    // we should be able to call kill without panics, even if the process already exited
+    child.make_assertion().is_not_alive();
+    child.kill();
+
+    // we should be able to call wait without panics and apply some assertions
+    child.wait().unwrap().code_is(0).no_stdout().no_stderr();
+}