Commit 8743bea
committed
fix(quoting): prevent control chars from triggering quotes in NonEscapedShellQuoter
The initial_quoting_with_show_control function was incorrectly treating
control characters as requiring quoting when show_control=true. This
caused test_control_chars to fail in the MinRustV CI check.
For NonEscapedShellQuoter (used in ls --quoting-style=shell):
- Control chars should NOT trigger quoting
- When show_control=false: they become '?' (not special)
- When show_control=true: shown as-is but still don't need quotes
- Only characters in shell_escaped_char_set trigger quoting
This differs from EscapedShellQuoter which uses dollar-quoting for
control characters.
Fixes the test expectation where shell-show mode should NOT wrap
control characters in quotes unless always_quote is set.1 parent 9930bff commit 8743bea
1 file changed
+10
-9
lines changedLines changed: 10 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
401 | | - | |
| 401 | + | |
402 | 402 | | |
403 | | - | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
411 | 412 | | |
412 | 413 | | |
413 | 414 | | |
| |||
0 commit comments