Merge pull request #9580 from Ecordonnier/eco/remove-fixme

cakebaker · web-flow · commit a0c14aacbbce · 2025-12-06T14:48:02.000+01:00
timeout: remove FIXME in test
diff --git a/tests/by-util/test_timeout.rs b/tests/by-util/test_timeout.rs
@@ -15,9 +15,6 @@ fn test_invalid_arg() {
     new_ucmd!().arg("--definitely-invalid").fails_with_code(125);
 }
 
-// FIXME: this depends on the system having true and false in PATH
-//        the best solution is probably to generate some test binaries that we can call for any
-//        utility that requires executing another program (kill, for instance)
 #[test]
 fn test_subcommand_return_code() {
     new_ucmd!().arg("1").arg("true").succeeds();

Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,6 @@ fn test_invalid_arg() {`
`15`	`15`	`new_ucmd!().arg("--definitely-invalid").fails_with_code(125);`
`16`	`16`	`}`
`17`	`17`
`18`		`-// FIXME: this depends on the system having true and false in PATH`
`19`		`-// the best solution is probably to generate some test binaries that we can call for any`
`20`		`-// utility that requires executing another program (kill, for instance)`
`21`	`18`	`#[test]`
`22`	`19`	`fn test_subcommand_return_code() {`
`23`	`20`	`new_ucmd!().arg("1").arg("true").succeeds();`