Skip to content

Commit ba08318

Browse files
committed
cat: Improve performance of formatting.
Issue #7518 Add a BufWriter over stdout when cat outputs any kind of formattted data. This improves performance considerably.
1 parent 7bd90bb commit ba08318

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/uu/cat/src/cat.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
// spell-checker:ignore (ToDO) nonprint nonblank nonprinting ELOOP
77
use std::fs::{metadata, File};
8-
use std::io::{self, IsTerminal, Read, Write};
8+
use std::io::{self, BufWriter, IsTerminal, Read, Write};
99
/// Unix domain socket support
1010
#[cfg(unix)]
1111
use std::net::Shutdown;
@@ -511,7 +511,9 @@ fn write_lines<R: FdReadable>(
511511
) -> CatResult<()> {
512512
let mut in_buf = [0; 1024 * 31];
513513
let stdout = io::stdout();
514-
let mut writer = stdout.lock();
514+
let stdout = stdout.lock();
515+
// Add a 32K buffer for stdout - this greatly improves performance.
516+
let mut writer = BufWriter::with_capacity(32 * 1024, stdout);
515517

516518
while let Ok(n) = handle.reader.read(&mut in_buf) {
517519
if n == 0 {
@@ -561,6 +563,7 @@ fn write_lines<R: FdReadable>(
561563
pos += offset + 1;
562564
}
563565
}
566+
writer.flush()?;
564567

565568
Ok(())
566569
}

0 commit comments

Comments
 (0)