Skip to content

Commit bf7ca75

Browse files
committed
fuzzing: fix should_pass evaluation in CI workflow
Fixed two bugs in the fuzzing workflow where matrix.test-target.name.should_pass was used instead of matrix.test-target.should_pass. This caused continue-on-error to always be true, making CI jobs pass even when fuzzers correctly detected incompatibilities.
1 parent 7881596 commit bf7ca75

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/fuzzing.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ jobs:
118118
- name: Run ${{ matrix.test-target.name }} for XX seconds
119119
id: run_fuzzer
120120
shell: bash
121-
continue-on-error: ${{ !matrix.test-target.name.should_pass }}
121+
continue-on-error: ${{ !matrix.test-target.should_pass }}
122122
run: |
123123
mkdir -p fuzz/stats
124124
STATS_FILE="fuzz/stats/${{ matrix.test-target.name }}.txt"
@@ -156,7 +156,7 @@ jobs:
156156
echo "Runs: $(grep -q "stat::number_of_executed_units" "$STATS_FILE" && grep "stat::number_of_executed_units" "$STATS_FILE" | awk '{print $2}' || echo "unknown")"
157157
echo "Execution Rate: $(grep -q "stat::average_exec_per_sec" "$STATS_FILE" && grep "stat::average_exec_per_sec" "$STATS_FILE" | awk '{print $2}' || echo "unknown") execs/sec"
158158
echo "New Units: $(grep -q "stat::new_units_added" "$STATS_FILE" && grep "stat::new_units_added" "$STATS_FILE" | awk '{print $2}' || echo "unknown")"
159-
echo "Expected: ${{ matrix.test-target.name.should_pass }}"
159+
echo "Expected: ${{ matrix.test-target.should_pass }}"
160160
if grep -q "SUMMARY: " "$STATS_FILE"; then
161161
echo "Status: $(grep "SUMMARY: " "$STATS_FILE" | head -1)"
162162
else

0 commit comments

Comments
 (0)