-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
Given that getting all of the stty tests to run on the integration test suite requires a overarching strategy on how the support running the test suite on Github Actions.
I did a bunch of investigating across open source projects to see how others have dealt with this issue and came across a "hack" that supposedly is all we need to be able to support running the stty tests. #9336
There are still a few underlying compatibility issues in the current stty implementation that are causing issues with the GNU test suite to get them to pass but I was able to get a draft with the tests passing locally for the following issues:
- The Baud value parsing for configuration values is able to parse a wide range of inputs that currently is not supported stty: Fixing baud parsing compatibility #9339
- There is no ability to parse MAC addresses when exporting the state and then re-importing the state
- The COLUMN env variable is not being parsed and used when printing the output
The other problem that we have is that the existing rust unit test infrastructure is that we are not able to run unit tests for this command because we have "ignore" flags set because cargo test does not run on a tty. In the long run a plan to add support for this should be added to test correctly.
I will try and split up the fixes to each of these sub problems into separate CR's.