Remove docker related files, align CI with the current curvelet workflow by restoring separate basic and secret-backed CurveLab jobs

Author: Phil-Dua

.github/workflows/ci.yml

@@ -8,36 +8,124 @@ on:
     branches: [main]
 
 jobs:
-  test:
+  test-basic:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         python-version: ["3.11", "3.12", "3.13"]
     steps:
       - uses: actions/checkout@v4
 
-      # Install system dependencies (like in your Docker container)
       - name: Install system dependencies
-        run: sudo apt-get update && sudo apt-get install -y libgl1 libglib2.0-0 python3-venv
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libgl1 libglib2.0-0 python3-venv
 
-      # Set up Python
       - uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
 
-      # Create virtual environment
-      - name: Create virtual environment
+      - name: Install dependencies
         run: |
-          python -m venv venv
-          source venv/bin/activate
-          python -m pip install --upgrade pip setuptools wheel
+          python -m pip install --upgrade pip
           python -m pip install -e .
           python -m pip install pytest ruff
 
-      # Run tests in the venv
-      - name: Run tests
+      - name: Run basic tests
+        env:
+          TMEQ_RUN_CURVELETS: "0"
+          QT_QPA_PLATFORM: "offscreen"
+        run: |
+          pytest -q -rs
+
+  # Secure build with CurveLab; skip on forked PRs (no secrets on forks).
+  test-curvelab:
+    if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }}
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.11", "3.12"]
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+
+      - name: Install system dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y build-essential gcc g++ make wget curl unzip libgl1 libglib2.0-0
+
+      - name: Fetch CurveLab archive
+        shell: bash
+        env:
+          FETCH_FDCT: ${{ secrets.FETCH_FDCT }}
+        run: |
+          set -euo pipefail
+          if [ -z "${FETCH_FDCT}" ]; then
+            echo "::error title=Missing secret::FETCH_FDCT is empty. It must download utils/CurveLab-2.1.3.tar.gz."
+            exit 1
+          fi
+          mkdir -p utils
+          cd utils
+          echo "-- Pre eval --"
+          ls -la
+          echo "Downloading CurveLab archive via FETCH_FDCT..."
+          eval "${FETCH_FDCT}"
+          echo "-- Post eval --"
+          ls -la
+          if [ ! -f "CurveLab-2.1.3.tar.gz" ]; then
+            echo "::error title=CurveLab archive missing after FETCH_FDCT::Expected utils/CurveLab-2.1.3.tar.gz to exist after running FETCH_FDCT."
+            echo "Files in utils/:"
+            ls -la
+            exit 1
+          fi
+          if command -v file >/dev/null 2>&1; then
+            echo "Downloaded archive mime-type:"
+            MIME="$(file -b --mime-type "CurveLab-2.1.3.tar.gz" || true)"
+            echo "${MIME}"
+            if [[ "${MIME}" == text/html* ]]; then
+              echo "::error title=CurveLab download returned HTML::Likely a 403/redirect. Showing first 40 lines:"
+              head -n 40 "CurveLab-2.1.3.tar.gz" || true
+              echo "Fix: update FETCH_FDCT to use 'curl --fail-with-body -fL ... -o CurveLab-2.1.3.tar.gz <URL>' so it fails on 403 instead of saving HTML."
+              exit 1
+            fi
+          fi
+
+      - name: Prepare FFTW + CurveLab toolchain
+        env:
+          FDCT: ""
+          FFTW: ""
+          CPPFLAGS: ""
+          LDFLAGS: ""
+        run: |
+          unset FDCT FFTW CPPFLAGS LDFLAGS
+          bash .github/ci_setup_curvelab.sh
+
+      - name: Validate CurveLab libraries
+        run: |
+          echo "Testing CurveLab compilation..."
+          if [ -z "${FDCT:-}" ]; then
+            echo "❌ FDCT environment variable not set by ci_setup_curvelab.sh"
+            exit 1
+          fi
+          echo "FDCT=${FDCT}"
+          ls -la "${FDCT}" || true
+          ls -la "${FDCT}/fdct_wrapping_cpp/src" || true
+          ls -la "${FDCT}/fdct3d/src" || true
+          test -f "${FDCT}/fdct_wrapping_cpp/src/libfdct_wrapping.a" && echo "✅ libfdct_wrapping.a built" || (echo "❌ libfdct_wrapping.a missing"; exit 1)
+          test -f "${FDCT}/fdct3d/src/libfdct3d.a" && echo "✅ libfdct3d.a built" || (echo "❌ libfdct3d.a missing"; exit 1)
+
+      - name: Install Python dependencies
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install -e ".[curvelops]"
+          python -m pip install pytest ruff
+
+      - name: Run tests with CurveLab
         env:
+          TMEQ_RUN_CURVELETS: "1"
           QT_QPA_PLATFORM: "offscreen"
         run: |
-          source venv/bin/activate
-          pytest -rs
+          pytest -q -rs