Skip to content

Commit d89bc0b

Browse files
committed
Remove problematic string_non_nominal soft constraint.
1 parent 9fc66b7 commit d89bc0b

File tree

4 files changed

+1
-8
lines changed

4 files changed

+1
-8
lines changed

asp/assign_weights.lp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ soft_weight(same_field_gte3,same_field_gte3_weight).
1414
soft_weight(count_twice,count_twice_weight).
1515
soft_weight(shape_cardinality,shape_cardinality_weight).
1616
soft_weight(number_nominal,number_nominal_weight).
17-
soft_weight(string_non_nominal,string_non_nominal_weight).
1817
soft_weight(bin_cardinality,bin_cardinality_weight).
1918
soft_weight(quant_bin,quant_bin_weight).
2019
soft_weight(agg_dim,agg_dim_weight).

asp/soft.lp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ soft(shape_cardinality,E) :- channel(E,shape), discrete_cardinality(E,C), C > 5.
3737
% @constraint Numbers should not be nominal.
3838
soft(number_nominal,E) :- type(E,nominal), field(E,F), fieldtype(F,number).
3939

40-
% @constraint Prefer nominal string fields
41-
soft(string_non_nominal,E) :- type(E,ordinal), field(E,F), fieldtype(F,string).
42-
soft(string_non_nominal,E) :- type(E,temporal), field(E,F), fieldtype(F,string).
43-
soft(string_non_nominal,E) :- type(E,quantitative), field(E,F), fieldtype(F,string).
44-
4540
% @constraint Binned quantitative field should not have too low cardinality.
4641
soft(bin_cardinality,E) :- type(E,quantitative), bin(E,_), enc_cardinality(E,C), C < 15.
4742

asp/weights.lp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#const count_twice_weight = 50.
1515
#const shape_cardinality_weight = 5.
1616
#const number_nominal_weight = 10.
17-
#const string_non_nominal_weight = 2.
1817
#const bin_cardinality_weight = 5.
1918
#const quant_bin_weight = 1.
2019
#const agg_dim_weight = 2.

draco/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def main(): # pragma: no cover
9595
else:
9696
logger.info(f"Processing query: {args.query.name} ...")
9797
if args.type == QueryType.asp:
98-
draco_query = args.query.read().split('\n')
98+
draco_query = args.query.read().split("\n")
9999
else:
100100
query_spec = json.load(args.query)
101101
d = args.base or os.path.dirname(args.query.name)

0 commit comments

Comments
 (0)