style: fix style errors in example app and library

Author: uxduck

analysis_options.yaml

@@ -1,4 +1,12 @@
 include: package:flutter_lints/flutter.yaml
 
 # Additional information about this file can be found at
+# https://dart.dev/tools/analysis
+# https://pub.dev/packages/flutter_lints
 # https://dart.dev/guides/language/analysis-options
+
+# To run this file, run `flutter analyze` or `mise lint`
+
+analyzer:
+  # generated code
+  exclude: ["test/serialization/push_api_test.dart"]

android/src/main/kotlin/uk/orth/push/serialization/PushApi.kt

@@ -567,12 +567,12 @@ class PushFlutterApi(private val binaryMessenger: BinaryMessenger, private val m
    * Hint: You can still include the title, body or other metadata in your
    * data payload to identify what notification the user tapped on.
    */
-  fun onNotificationTap(dataArg: Map<String?, Any?>, callback: (Result<Unit>) -> Unit)
+  fun onNotificationTap(messageArg: Map<String?, Any?>, callback: (Result<Unit>) -> Unit)
 {
     val separatedMessageChannelSuffix = if (messageChannelSuffix.isNotEmpty()) ".$messageChannelSuffix" else ""
     val channelName = "dev.flutter.pigeon.push.PushFlutterApi.onNotificationTap$separatedMessageChannelSuffix"
     val channel = BasicMessageChannel<Any?>(binaryMessenger, channelName, codec)
-    channel.send(listOf(dataArg)) {
+    channel.send(listOf(messageArg)) {
       if (it is List<*>) {
         if (it.size > 1) {
           callback(Result.failure(FlutterError(it[0] as String, it[1] as String, it[2] as String?)))

darwin/Classes/serialization/PushApi.h

@@ -179,7 +179,7 @@ extern void SetUpPUPushHostApiWithSuffix(id<FlutterBinaryMessenger> binaryMessen
 ///
 /// Hint: You can still include the title, body or other metadata in your
 /// data payload to identify what notification the user tapped on.
-- (void)onNotificationTapData:(NSDictionary<NSString *, id> *)data completion:(void (^)(FlutterError *_Nullable))completion;
+- (void)onNotificationTapMessage:(NSDictionary<NSString *, id> *)message completion:(void (^)(FlutterError *_Nullable))completion;
 - (void)onNewTokenToken:(NSString *)token completion:(void (^)(FlutterError *_Nullable))completion;
 - (void)onOpenNotificationSettingsWithCompletion:(void (^)(FlutterError *_Nullable))completion;
 @end

darwin/Classes/serialization/PushApi.m

@@ -555,14 +555,14 @@ - (void)onBackgroundMessageMessage:(PURemoteMessage *)arg_message completion:(vo
     } 
   }];
 }
-- (void)onNotificationTapData:(NSDictionary<NSString *, id> *)arg_data completion:(void (^)(FlutterError *_Nullable))completion {
+- (void)onNotificationTapMessage:(NSDictionary<NSString *, id> *)arg_message completion:(void (^)(FlutterError *_Nullable))completion {
   NSString *channelName = [NSString stringWithFormat:@"%@%@", @"dev.flutter.pigeon.push.PushFlutterApi.onNotificationTap", _messageChannelSuffix];
   FlutterBasicMessageChannel *channel =
     [FlutterBasicMessageChannel
       messageChannelWithName:channelName
       binaryMessenger:self.binaryMessenger
       codec:PUGetPushApiCodec()];
-  [channel sendMessage:@[arg_data ?: [NSNull null]] reply:^(NSArray<id> *reply) {
+  [channel sendMessage:@[arg_message ?: [NSNull null]] reply:^(NSArray<id> *reply) {
     if (reply != nil) {
       if (reply.count > 1) {
         completion([FlutterError errorWithCode:reply[0] message:reply[1] details:reply[2]]);

example/analysis_options.yaml

@@ -1,29 +1,11 @@
-# This file configures the analyzer, which statically analyzes Dart code to
-# check for errors, warnings, and lints.
-#
-# The issues identified by the analyzer are surfaced in the UI of Dart-enabled
-# IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be
-# invoked from the command line by running `flutter analyze`.
-
-# The following line activates a set of recommended lints for Flutter apps,
-# packages, and plugins designed to encourage good coding practices.
 include: package:flutter_lints/flutter.yaml
 
-linter:
-  # The lint rules applied to this project can be customized in the
-  # section below to disable rules from the `package:flutter_lints/flutter.yaml`
-  # included above or to enable additional rules. A list of all available lints
-  # and their documentation is published at
-  # https://dart-lang.github.io/linter/lints/index.html.
-  #
-  # Instead of disabling a lint rule for the entire project in the
-  # section below, it can also be suppressed for a single line of code
-  # or a specific dart file by using the `// ignore: name_of_lint` and
-  # `// ignore_for_file: name_of_lint` syntax on the line or in the file
-  # producing the lint.
-  rules:
-    # avoid_print: false  # Uncomment to disable the `avoid_print` rule
-    # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
-
 # Additional information about this file can be found at
+# https://dart.dev/tools/analysis
+# https://pub.dev/packages/flutter_lints
 # https://dart.dev/guides/language/analysis-options
+
+linter:
+  rules:
+    # Printing is useful for developers in this example app
+    avoid_print: false

example/lib/metadata_sliver.dart

@@ -61,7 +61,7 @@ class MetadataSliver extends HookWidget {
               Expanded(child: Text(pushToken.value.toString()))
             ],
           ),
-          DarwinRegisterUnregisterWidget()
+          const DarwinRegisterUnregisterWidget()
         ],
       ),
     );

example/lib/notification_permission_sliver.dart

@@ -6,7 +6,7 @@ import 'package:push/push.dart';
 import 'package:push_example/text_row.dart';
 
 class NotificationPermissionSliver extends HookWidget {
-  const NotificationPermissionSliver({Key? key}) : super(key: key);
+  const NotificationPermissionSliver({super.key});
 
   @override
   Widget build(BuildContext context) {

example/lib/remote_message_widget.dart

@@ -5,7 +5,7 @@ import 'package:push_example/text_row.dart';
 class RemoteMessageWidget extends StatelessWidget {
   final RemoteMessage? remoteMessage;
 
-  const RemoteMessageWidget(this.remoteMessage, {Key? key}) : super(key: key);
+  const RemoteMessageWidget(this.remoteMessage, {super.key});
 
   @override
   Widget build(BuildContext context) {

example/lib/remote_messages_widget.dart

@@ -5,7 +5,7 @@ import 'package:push_example/text_row.dart';
 class RemoteMessagesWidget extends StatelessWidget {
   final List<RemoteMessage> remoteMessages;
 
-  const RemoteMessagesWidget(this.remoteMessages, {Key? key}) : super(key: key);
+  const RemoteMessagesWidget(this.remoteMessages, {super.key});
 
   @override
   Widget build(BuildContext context) {
@@ -14,19 +14,17 @@ class RemoteMessagesWidget extends StatelessWidget {
     }
     return Column(
       children: [
-        ...remoteMessages
-            .map((message) => Padding(
-                  padding: const EdgeInsets.symmetric(vertical: 4),
-                  child: Column(
-                    crossAxisAlignment: CrossAxisAlignment.stretch,
-                    children: [
-                      TextRow("Title", message.notification?.title.toString()),
-                      TextRow("Body", message.notification?.body.toString()),
-                      TextRow("Data", message.data?.toString())
-                    ],
-                  ),
-                ))
-            .toList()
+        ...remoteMessages.map((message) => Padding(
+              padding: const EdgeInsets.symmetric(vertical: 4),
+              child: Column(
+                crossAxisAlignment: CrossAxisAlignment.stretch,
+                children: [
+                  TextRow("Title", message.notification?.title.toString()),
+                  TextRow("Body", message.notification?.body.toString()),
+                  TextRow("Data", message.data?.toString())
+                ],
+              ),
+            ))
       ],
     );
   }

example/lib/text_row.dart

@@ -6,7 +6,7 @@ class TextRow extends StatelessWidget {
   final String label;
   final String? text;
 
-  const TextRow(this.label, this.text, {Key? key}) : super(key: key);
+  const TextRow(this.label, this.text, {super.key});
 
   @override
   Widget build(BuildContext context) => RichText(