Skip to content

Commit 8a8c907

Browse files
[oneMKL][spblas] add missing 'const' keyword for alpha, beta, and input array, and remove 'y' from input list in sparse::trsv() spec. (#498)
1 parent cf9bc8f commit 8a8c907

File tree

4 files changed

+16
-26
lines changed

4 files changed

+16
-26
lines changed

source/elements/oneMKL/source/domains/spblas/gemvdot.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ gemvdot (Buffer version)
4545
4646
void gemvdot (sycl::queue &queue,
4747
oneapi::mkl::transpose transpose_val,
48-
fp alpha,
48+
const fp alpha,
4949
oneapi::mkl::sparse::matrix_handle_t A_handle,
5050
sycl::buffer<fp, 1> &x,
51-
fp beta,
51+
const fp beta,
5252
sycl::buffer<fp, 1> &y,
5353
sycl::buffer<fp, 1> &d);
5454
@@ -135,10 +135,10 @@ gemvdot (USM version)
135135
136136
sycl::event gemvdot (sycl::queue &queue,
137137
oneapi::mkl::transpose transpose_val,
138-
fp alpha,
138+
const fp alpha,
139139
oneapi::mkl::sparse::matrix_handle_t A_handle,
140-
fp *x,
141-
fp beta,
140+
const fp *x,
141+
const fp beta,
142142
fp *y,
143143
fp *d,
144144
const std::vector<sycl::event> &dependencies = {});

source/elements/oneMKL/source/domains/spblas/symv.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ symv (Buffer version)
3939
4040
void symv (sycl::queue &queue,
4141
oneapi::mkl::uplo uplo_val,
42-
fp alpha,
42+
const fp alpha,
4343
oneapi::mkl::sparse::matrix_handle_t A_handle,
4444
sycl::buffer<fp, 1> &x,
45-
fp beta,
45+
const fp beta,
4646
sycl::buffer<fp, 1> &y);
4747
4848
}
@@ -125,10 +125,10 @@ symv (USM version)
125125
126126
sycl::event symv (sycl::queue &queue,
127127
oneapi::mkl::uplo uplo_val,
128-
fp alpha,
128+
const fp alpha,
129129
oneapi::mkl::sparse::matrix_handle_t A_handle,
130-
fp *x,
131-
fp beta,
130+
const fp *x,
131+
const fp beta,
132132
fp *y,
133133
const std::vector<sycl::event> &dependencies = {});
134134

source/elements/oneMKL/source/domains/spblas/trmv.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ trmv (Buffer version)
3939
oneapi::mkl::uplo uplo_val
4040
oneapi::mkl::transpose transpose_val,
4141
oneapi::mkl::diag diag_val
42-
fp alpha,
42+
const fp alpha,
4343
oneapi::mkl::sparse::matrix_handle_t A_handle,
4444
sycl::buffer<fp, 1> &x,
45-
fp beta,
45+
const fp beta,
4646
sycl::buffer<fp, 1> &y);
4747
4848
}
@@ -138,10 +138,10 @@ trmv (USM version)
138138
oneapi::mkl::uplo uplo_val
139139
oneapi::mkl::transpose transpose_val,
140140
oneapi::mkl::diag diag_val
141-
fp alpha,
141+
const fp alpha,
142142
oneapi::mkl::sparse::matrix_handle_t A_handle,
143-
fp *x,
144-
fp beta,
143+
const fp *x,
144+
const fp beta,
145145
fp *y
146146
const std::vector<sycl::event> &dependencies = {});
147147

source/elements/oneMKL/source/domains/spblas/trsv.rst

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,6 @@ trsv (Buffer version)
8282
equal to the number of columns of matrix :math:`\text{op}(A)`.
8383

8484

85-
y
86-
SYCL memory object containing an array of size at least
87-
equal to the number of rows of matrix :math:`\text{op}(A)`.
88-
89-
9085
.. container:: section
9186

9287

@@ -129,7 +124,7 @@ trsv (USM version)
129124
oneapi::mkl::transpose transpose_val,
130125
oneapi::mkl::diag diag_val
131126
oneapi::mkl::sparse::matrix_handle_t A_handle,
132-
fp *x,
127+
const fp *x,
133128
fp *y
134129
const std::vector<sycl::event> &dependencies = {});
135130
@@ -171,11 +166,6 @@ trsv (USM version)
171166
equal to the number of columns of matrix :math:`\text{op}(A)`.
172167

173168

174-
y
175-
Device-accessible USM object containing an array of size at least
176-
equal to the number of rows of matrix :math:`\text{op}(A)`.
177-
178-
179169
dependencies
180170
List of events that oneapi::mkl::sparse::trmv routine depends on.
181171
If omitted, defaults to no dependencies.

0 commit comments

Comments
 (0)