Better to specify the amount of results for __result_and_scratch_storage_impl
at compile-time
#2164
Closed
SergeyKopienko
started this conversation in
Ideas
Replies: 2 comments
-
Seems this is already implemented. @SergeyKopienko is it OK to close the discussion, or is there more to consider? |
Beta Was this translation helpful? Give feedback.
0 replies
-
Yes, sure. It was implemented in the PR #2167 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I think probably better to specify the amount of results for
__result_and_scratch_storage_impl
at compile-time:oneDPL/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_utils.h
Line 578 in e90b267
From my point of view it's implementable and as also we can also return results from
__result_and_scratch_storage_impl
- I seen some requests for that from @MikeDvorskiy side in his PRs.Of course, I propose that only for
std::size_t __result_n
parameter, not forstd::size_t __scratch_n
parameter.As some benefit of this approach we able to return
std::tuple
from__result_and_scratch_storage_impl
when it contains more then one result inside.Beta Was this translation helpful? Give feedback.
All reactions