Add missing includes in random implementation; fix issue in partial specialization#2620
Open
ferdymercury wants to merge 3 commits intouxlfoundation:mainfrom
Open
Add missing includes in random implementation; fix issue in partial specialization#2620ferdymercury wants to merge 3 commits intouxlfoundation:mainfrom
ferdymercury wants to merge 3 commits intouxlfoundation:mainfrom
Conversation
…transitive sycl inclusion for randomcommon
ferdymercury
force-pushed
the
randomimplfixes
branch
from
7ae90f3 to
5b0028f
Compare
Author
|
I just updated the description. |
it's supposed to happen already in sycl_defs within the collection header oneapi/dpl/random
danhoeflinger
changed the title
Contributor
|
@ferdymercury this LGTM, but we are in the middle of trying to get a release packaged up so it will need to wait a little bit to be merged. (I hope ~1 week). Thanks for the contribution! |
Author
Thanks. No hurries at all from my side |
andreyfe1
approved these changes
Mar 23, 2026
danhoeflinger
requested changes
Mar 23, 2026
Contributor
danhoeflinger
left a comment
danhoeflinger
left a comment
There was a problem hiding this comment.
Just putting a hold on this until we get through the release window here. No changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to use the headers inside random_impl as a standalone header-only library compiled with SYCL support.
In other words, I have a file main.cpp that includes normaldistribution.h which I compile with -I/path/to/random_impl and the -fsycl flags.