Skip to content

Commit b8f50f8

Browse files
committed
Apply suggestions from code review
1 parent f09804d commit b8f50f8

File tree

5 files changed

+14
-9
lines changed

5 files changed

+14
-9
lines changed

include/oneapi/tbb/detail/_flow_graph_nodes_deduction.h

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/*
2-
Copyright (c) 2005-2025 Intel Corporation
2+
Copyright (c) 2005-2024 Intel Corporation
3+
Copyright (c) 2026 UXL Foundation Contributors
34
45
Licensed under the Apache License, Version 2.0 (the "License");
56
you may not use this file except in compliance with the License.
@@ -66,16 +67,16 @@ template <typename Input, typename Output>
6667
struct extract_body_types<Output Input::*> : body_types<Input, Output> {};
6768

6869
template <typename Body>
69-
using input_type = typename extract_body_types<Body>::input_type;
70+
using input_type_of = typename extract_body_types<Body>::input_type;
7071

7172
template <typename Body>
72-
using output_type = typename extract_body_types<Body>::output_type;
73+
using output_type_of = typename extract_body_types<Body>::output_type;
7374

7475
// Deduction guides for Flow Graph nodes
7576

7677
template <typename GraphOrSet, typename Body>
7778
input_node(GraphOrSet&&, Body)
78-
->input_node<output_type<Body>>;
79+
->input_node<output_type_of<Body>>;
7980

8081
#if __TBB_PREVIEW_FLOW_GRAPH_NODE_SET
8182

@@ -110,7 +111,7 @@ queue_node(const NodeSet&)
110111

111112
template <typename GraphOrProxy, typename Sequencer>
112113
sequencer_node(GraphOrProxy&&, Sequencer)
113-
->sequencer_node<input_type<Sequencer>>;
114+
->sequencer_node<input_type_of<Sequencer>>;
114115

115116
#if __TBB_PREVIEW_FLOW_GRAPH_NODE_SET
116117
template <typename NodeSet, typename Compare>
@@ -157,8 +158,8 @@ join_node(const node_set<order::preceding, Successor, Successors...>)
157158

158159
template <typename GraphOrProxy, typename Body, typename... Bodies>
159160
join_node(GraphOrProxy&&, Body, Bodies...)
160-
->join_node<std::tuple<input_type<Body>, input_type<Bodies>...>,
161-
key_matching<join_key_t<output_type<Body>>>>;
161+
->join_node<std::tuple<input_type_of<Body>, input_type_of<Bodies>...>,
162+
key_matching<join_key_t<output_type_of<Body>>>>;
162163

163164
#if __TBB_PREVIEW_FLOW_GRAPH_NODE_SET
164165
template <typename... Predecessors>
@@ -183,12 +184,12 @@ template <typename GraphOrSet, typename Body, typename Policy>
183184
function_node(GraphOrSet&&,
184185
size_t, Body,
185186
Policy, node_priority_t = no_priority)
186-
->function_node<input_type<Body>, output_type<Body>, Policy>;
187+
->function_node<input_type_of<Body>, output_type_of<Body>, Policy>;
187188

188189
template <typename GraphOrSet, typename Body>
189190
function_node(GraphOrSet&&, size_t,
190191
Body, node_priority_t = no_priority)
191-
->function_node<input_type<Body>, output_type<Body>, queueing>;
192+
->function_node<input_type_of<Body>, output_type_of<Body>, queueing>;
192193

193194
template <typename Output>
194195
struct continue_output {

test/conformance/conformance_flowgraph.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/*
22
Copyright (c) 2020-2025 Intel Corporation
3+
Copyright (c) 2026 UXL Foundation Contributors
34
45
Licensed under the Apache License, Version 2.0 (the "License");
56
you may not use this file except in compliance with the License.

test/conformance/conformance_function_node.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/*
22
Copyright (c) 2020-2025 Intel Corporation
3+
Copyright (c) 2026 UXL Foundation Contributors
34
45
Licensed under the Apache License, Version 2.0 (the "License");
56
you may not use this file except in compliance with the License.

test/conformance/conformance_sequencer_node.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/*
22
Copyright (c) 2020-2025 Intel Corporation
3+
Copyright (c) 2026 UXL Foundation Contributors
34
45
Licensed under the Apache License, Version 2.0 (the "License");
56
you may not use this file except in compliance with the License.

test/tbb/test_join_node_key_matching.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/*
22
Copyright (c) 2005-2025 Intel Corporation
3+
Copyright (c) 2026 UXL Foundation Contributors
34
45
Licensed under the Apache License, Version 2.0 (the "License");
56
you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)