Skip to content

Commit 947ecbc

Browse files
Increase tolerance in sparse logistic regression test (#2027)
* Increase tolerance in sparse logistic regression test * Update rtol
1 parent 07f390e commit 947ecbc

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

onedal/linear_model/tests/test_logistic_regression.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ def test_csr(queue, dtype, dims):
8989
model_sp.fit(X_sp, y, queue=queue)
9090
pred_sp = model_sp.predict(X_sp, queue=queue)
9191

92-
assert_allclose(pred, pred_sp)
93-
assert_allclose(model.coef_, model_sp.coef_)
94-
assert_allclose(model.intercept_, model_sp.intercept_)
92+
rtol = 2e-4
93+
assert_allclose(pred, pred_sp, rtol=rtol)
94+
assert_allclose(model.coef_, model_sp.coef_, rtol=rtol)
95+
assert_allclose(model.intercept_, model_sp.intercept_, rtol=rtol)

sklearnex/linear_model/tests/test_logreg.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ def test_csr(queue, dtype, dims):
127127
pred_sp = model_sp.predict(X_sp)
128128
prob_sp = model_sp.predict_proba(X_sp)
129129

130-
assert_allclose(pred, pred_sp)
131-
assert_allclose(prob, prob_sp)
132-
assert_allclose(model.coef_, model_sp.coef_, rtol=1e-4)
133-
assert_allclose(model.intercept_, model_sp.intercept_, rtol=1e-4)
130+
rtol = 2e-4
131+
assert_allclose(pred, pred_sp, rtol=rtol)
132+
assert_allclose(prob, prob_sp, rtol=rtol)
133+
assert_allclose(model.coef_, model_sp.coef_, rtol=rtol)
134+
assert_allclose(model.intercept_, model_sp.intercept_, rtol=rtol)

0 commit comments

Comments
 (0)