Skip to content

Commit f3a5c81

Browse files
Alexsandrussnapetrov
authored andcommitted
Numpy versions change; in-function imports removal; load_boston removal (#1041)
1 parent 2694e6d commit f3a5c81

File tree

3 files changed

+29
-21
lines changed

3 files changed

+29
-21
lines changed

daal4py/sklearn/_utils.py

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
import numpy as np
1818
import sys
19+
import os
20+
import warnings
1921

2022
from daal4py import _get__daal_link_version__ as dv
2123
from sklearn import __version__ as sklearn_version
@@ -25,10 +27,21 @@
2527
from distutils.version import LooseVersion as Version
2628
import logging
2729

30+
try:
31+
from pandas import DataFrame
32+
from pandas.core.dtypes.cast import find_common_type
33+
pandas_is_imported = True
34+
except (ImportError, ModuleNotFoundError):
35+
pandas_is_imported = False
36+
37+
try:
38+
from daal4py.oneapi import is_in_sycl_ctxt as is_in_ctx
39+
ctx_imported = True
40+
except (ImportError, ModuleNotFoundError):
41+
ctx_imported = False
42+
2843

2944
def set_idp_sklearn_verbose():
30-
import warnings
31-
import os
3245
logLevel = os.environ.get("IDP_SKLEARN_VERBOSE")
3346
try:
3447
if logLevel is not None:
@@ -79,14 +92,10 @@ def parse_dtype(dt):
7992

8093

8194
def getFPType(X):
82-
try:
83-
from pandas import DataFrame
84-
from pandas.core.dtypes.cast import find_common_type
95+
if pandas_is_imported:
8596
if isinstance(X, DataFrame):
8697
dt = find_common_type(X.dtypes.tolist())
8798
return parse_dtype(dt)
88-
except ImportError:
89-
pass
9099

91100
dt = getattr(X, 'dtype', None)
92101
return parse_dtype(dt)
@@ -128,26 +137,24 @@ def get_patch_message(s):
128137

129138

130139
def is_in_sycl_ctxt():
131-
try:
132-
from daal4py.oneapi import is_in_sycl_ctxt as is_in_ctx
140+
if ctx_imported:
133141
return is_in_ctx()
134-
except ModuleNotFoundError:
142+
else:
135143
return False
136144

137145

138146
def is_DataFrame(X):
139-
try:
147+
if pandas_is_imported:
140148
from pandas import DataFrame
141149
return isinstance(X, DataFrame)
142-
except ImportError:
150+
else:
143151
return False
144152

145153

146154
def get_dtype(X):
147-
try:
148-
from pandas.core.dtypes.cast import find_common_type
155+
if pandas_is_imported:
149156
return find_common_type(list(X.dtypes)) if is_DataFrame(X) else X.dtype
150-
except ImportError:
157+
else:
151158
return getattr(X, "dtype", None)
152159

153160

requirements-dev.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Cython==0.29.24 ; python_version <= '3.9'
22
Cython==0.29.25 ; python_version >= '3.10'
33
Jinja2==3.0.3
4-
numpy==1.21.0 ; python_version <= '3.8'
5-
numpy==1.19.3 ; python_version == '3.9'
6-
numpy==1.22.0 ; python_version >= '3.10'
4+
numpy==1.19.5 ; python_version == '3.6'
5+
numpy==1.21.6 ; python_version == '3.7'
6+
numpy==1.23.2 ; python_version >= '3.8'
77
pybind11==2.8.0
88
cmake==3.21.3

sklearnex/tests/test_run_to_run_stability_tests.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
from sklearn.manifold import TSNE
3333
from sklearn.model_selection import train_test_split
3434

35-
from sklearn.datasets import (make_classification, load_breast_cancer,
36-
load_diabetes, load_iris, load_boston)
35+
from sklearn.datasets import (make_classification, make_regression,
36+
load_breast_cancer, load_diabetes, load_iris)
3737
from sklearn.metrics import pairwise_distances, roc_auc_score
3838
from scipy import sparse
3939
from daal4py.sklearn._utils import daal_check_version
@@ -113,7 +113,8 @@ def _run_test(model, methods, dataset):
113113
X2 = sparse.csr_matrix(X2)
114114
datasets.append((X2, y2))
115115
elif dataset == 'regression':
116-
X1, y1 = load_boston(return_X_y=True)
116+
X1, y1 = make_regression(n_samples=500, n_features=10,
117+
noise=64.0, random_state=42)
117118
datasets.append((X1, y1))
118119
X2, y2 = load_diabetes(return_X_y=True)
119120
datasets.append((X2, y2))

0 commit comments

Comments
 (0)