ENH: removing DPCTL dep from building (#1685)

* ENH: updates for onedal.common module
---------
Co-authored-by: Nikita Kulikov <[email protected]>

* removed unused files

* update onedal/dal.cpp

* ENH: removing DPCTL dep from building

* fix onedal test

pytest fixture retruns empty list, not None. Will be fixed for all test suits seperately

* Update onedal/common/_policy.py

* minor update

* disabled tests for outdated functionality

* removed DPCTL include usage from CMakelist

Author: samir-nasibli

onedal/datatypes/tests/test_data.py

@@ -144,6 +144,13 @@ def test_input_format_f_contiguous_pandas(queue, dtype):
     _test_input_format_f_contiguous_pandas(queue, dtype)
 
 
+# TODO:
+# Currently `dpctl_to_table` is not used in onedal estimators.
+# The test will be enabled after future data management update, that brings
+# re-impl of conversions between onedal tables and usm ndarrays.
+@pytest.mark.skip(
+    reason="Currently removed. Will be enabled after data management update"
+)
 @pytest.mark.skipif(not dpctl_available, reason="requires dpctl>=0.14")
 @pytest.mark.parametrize("queue", get_queues("cpu,gpu"))
 @pytest.mark.parametrize("dtype", [np.float32, np.float64, np.int32, np.int64])
@@ -171,6 +178,13 @@ def test_input_format_c_contiguous_dpctl(queue, dtype):
     assert x_dpt_from_table.flags.c_contiguous
 
 
+# TODO:
+# Currently `dpctl_to_table` is not used in onedal estimators.
+# The test will be enabled after future data management update, that brings
+# re-impl of conversions between onedal tables and usm ndarrays.
+@pytest.mark.skip(
+    reason="Currently removed. Will be enabled after data management update"
+)
 @pytest.mark.skipif(not dpctl_available, reason="requires dpctl>=0.14")
 @pytest.mark.parametrize("queue", get_queues("cpu,gpu"))
 @pytest.mark.parametrize("dtype", [np.float32, np.float64, np.int32, np.int64])

scripts/CMakeLists.txt

@@ -63,10 +63,6 @@ message(STATUS "PYTHON_INCLUDE_DIR:" ${PYTHON_INCLUDE_DIR})
 message(STATUS "PYTHON_LIBRARY_DIR:" ${PYTHON_LIBRARY_DIR})
 message(STATUS "NUMPY_INCLUDE_DIRS:" ${NUMPY_INCLUDE_DIRS})
 
-if(ONEDAL_DPCTL_INTEGRATION)
-    message(STATUS "DPCTL_INCLUDE_DIR:" ${DPCTL_INCLUDE_DIR})
-endif()
-
 if(IFACE STREQUAL "dpc")
     set(IFACE_IS_DPC ON)
 else()
@@ -170,11 +166,6 @@ elseif(IFACE_IS_DPC OR IFACE_IS_SPMD_DPC)
         "ONEDAL_DATA_PARALLEL"
         "NPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION")
 
-    if(ONEDAL_DPCTL_INTEGRATION)
-        list(APPEND COMPILE_DEFINITIONS
-             "ONEDAL_DPCTL_INTEGRATION")
-    endif()
-
     if(IFACE_IS_SPMD_DPC)
         list(APPEND COMPILE_DEFINITIONS
              "ONEDAL_DATA_PARALLEL_SPMD")
@@ -203,10 +194,6 @@ endif()
 set(EXTERNAL_LINK_DIRECTORIES ${PYTHON_LIBRARY_DIR} ${oneDAL_LIBRARY_DIR})
 set(EXTERNAL_LINK_LIBRARIES ${ONEDAL_LIBRARIES})
 
-if(ONEDAL_DPCTL_INTEGRATION)
-list(APPEND EXTERNAL_INCLUDE_DIRECTORIES ${DPCTL_INCLUDE_DIR})
-endif()
-
 if(IFACE_IS_SPMD_DPC)
 list(APPEND EXTERNAL_LINK_LIBRARIES ${MPI_LIBRARY})
 list(APPEND EXTERNAL_LINK_DIRECTORIES ${MPI_LIBRARY_DIR})

scripts/build_backend.py

@@ -124,24 +124,6 @@ def custom_build_cmake_clib(
 ):
     import pybind11
 
-    try:
-        import dpctl
-
-        dpctl_available = dpctl.__version__ >= "0.14"
-        dpctl_include = dpctl.get_include()
-    except ImportError:
-        import importlib.util
-
-        try:
-            dpctl_include = os.path.join(
-                importlib.util.find_spec("dpctl").submodule_search_locations[0], "include"
-            )
-            dpctl_available = dpctl_include is not None
-        except AttributeError:
-            dpctl_available = False
-
-    log.info(f"Is DPCTL available: {str(dpctl_available)}")
-
     root_dir = os.path.normpath(jp(os.path.dirname(__file__), ".."))
     log.info(f"Project directory is: {root_dir}")
 
@@ -207,12 +189,6 @@ def custom_build_cmake_clib(
         "-DoneDAL_USE_PARAMETERS_LIB=" + use_parameters_arg,
     ]
 
-    if dpctl_available:
-        cmake_args += [
-            "-DDPCTL_INCLUDE_DIR=" + dpctl_include,
-            "-DONEDAL_DPCTL_INTEGRATION:BOOL=ON",
-        ]
-
     if build_distribute:
         cmake_args += [
             "-DMPI_INCLUDE_DIRS=" + MPI_INCDIRS,