Skip to content

[enhancement] Enable array API for SVM algorithms #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 125 commits into
base: main
Choose a base branch
from
Draft

[enhancement] Enable array API for SVM algorithms #2209

wants to merge 125 commits into from
+1,520 −1,875

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Dec 4, 2024

Description

Add a comprehensive description of proposed changes

List associated issue number(s) if exist(s): #6 (for example)

Documentation PR (if needed): #1340 (for example)

Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@icfaust
Copy link
Contributor Author

icfaust commented Dec 4, 2024

/intelci: run

@icfaust icfaust mentioned this pull request Dec 5, 2024
Merged
13 tasks
@icfaust
Copy link
Contributor Author

icfaust commented Dec 5, 2024

/intelci: run

@david-cortes-intel
Copy link
Contributor

@icfaust Please remember to add the classes that this PR covers to this list in the docs:

scikit-learn-intelex/doc/sources/array_api.rst

Line 84 in 91885a3

Supported classes

@codecov Codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.07380% with 108 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sklearnex/svm/_base.py 80.63% 50 Missing and 11 partials ⚠️
sklearnex/svm/_classes.py 85.48% 16 Missing and 2 partials ⚠️
onedal/svm/tests/test_csr_svm.py 46.15% 11 Missing and 3 partials ⚠️
onedal/svm/svm.py 87.69% 7 Missing and 1 partial ⚠️
sklearnex/utils/class_weight.py 0.00% 6 Missing ⚠️
sklearnex/svm/__init__.py 66.66% 0 Missing and 1 partial ⚠️
Flag Coverage Δ
azure 78.56% <77.85%> (-1.88%) ⬇️
github ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/svm/__init__.py 100.00% <100.00%> (ø)
sklearnex/_utils.py 81.01% <100.00%> (-4.53%) ⬇️
sklearnex/svm/__init__.py 50.00% <66.66%> (-16.67%) ⬇️
sklearnex/utils/class_weight.py 28.20% <0.00%> (-43.23%) ⬇️
onedal/svm/svm.py 88.39% <87.69%> (-2.36%) ⬇️
onedal/svm/tests/test_csr_svm.py 52.72% <46.15%> (ø)
sklearnex/svm/_classes.py 85.48% <85.48%> (ø)
sklearnex/svm/_base.py 80.63% <80.63%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icfaust
Copy link
Contributor Author

icfaust commented Oct 20, 2025

/intelci: run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-cortes-intel david-cortes-intel david-cortes-intel left review comments

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss will be requested when the pull request is marked ready for review Alexsandruss is a code owner

@yuejiaointel yuejiaointel Awaiting requested review from yuejiaointel yuejiaointel will be requested when the pull request is marked ready for review yuejiaointel is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 will be requested when the pull request is marked ready for review ahuber21 is a code owner

@ethanglaser ethanglaser Awaiting requested review from ethanglaser ethanglaser will be requested when the pull request is marked ready for review ethanglaser is a code owner

@Vika-F Vika-F Awaiting requested review from Vika-F Vika-F will be requested when the pull request is marked ready for review Vika-F is a code owner

@maria-Petrova maria-Petrova Awaiting requested review from maria-Petrova maria-Petrova will be requested when the pull request is marked ready for review maria-Petrova is a code owner

@syakov-intel syakov-intel Awaiting requested review from syakov-intel syakov-intel will be requested when the pull request is marked ready for review syakov-intel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@icfaust @david-cortes-intel